Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Commits on Aug 17, 2012
  1. @lelutin @rlbdv

    Remove useless code in main.py around the -d option

    lelutin authored rlbdv committed
    While debugging another problem with BUP_DIR, I saw a part of the
    code that looked kinda suspicious (not in itself, but in the context of
    the file):
    
      115 subcmd_env = os.environ
      116 if dest_dir:
      117     subcmd_env.update({"BUP_DIR" : dest_dir})
    
    the subcmd_env variable is never used in main.py. However, when I
    removed that part, the -d option stopped working and bup used ~/.bup
    instead: so it _is_ doing what we want it to.
    
    The reason why it's working is that line 115 is actually not creating a
    copy of the dict, but rather simply pointing to the same dict. so the
    call to update() actually changes the environment for the main program,
    which is actually quite alright (e.g. it supercedes the environment
    variable and ensures that the path given to -d is inherited into
    subprocesses)
    
    Now the problem is that this code is very not obvious about what it
    does. Plus, it's a couple of useless lines that we need to maintain.
    Let's just remove any extraneous work and make the addition to the
    environment triggered by the -d option as obvious and concise as
    possible.
    
    Signed-off-by: Gabriel Filion <lelutin@gmail.com>
    Reviewed-by: Rob Browning <rlb@defaultvalue.org>
Commits on Dec 1, 2010
  1. @lelutin

    add a tag command

    lelutin authored committed
    Currently implemented: list all tags, add a tag on a specific commit or
    head, delete a known tag.
    
    Also, make vfs expose a new directory called '/.tag' which contains a
    link for each tag to its associated commit directory situated in
    '/.commit'. Finally, make tags appear as symlinks on branch directories
    on which the tagged commit is visible.
    
    Signed-off-by: Gabriel Filion <lelutin@gmail.com>
Something went wrong with that request. Please try again.