ThreadLocal based Inspektr PrincipalResolver #1957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * components that are not tightly coupled with core CAS APIs, for example audit principal resolver component, etc. | ||
| * <p> | ||
| * The thread local state carried by this class should be set by core CAS components processing core authentication and | ||
| * CAS protocol events e.g. <code>AbstractAuthenticationManager</code>, <code>CentralAuthenticationServiceImpl</code>, etc. |
There was a problem hiding this comment.
Minor suggestion: try using {@link}. Helps with future refactoring, if the class should be renamed, etc.
There was a problem hiding this comment.
Will add the link, but that will require compile dependency on the module in question :-)
|
Thanks @dima767 Looks excellent. Few minor questions here and there. |
mmoayyed
pushed a commit
that referenced
this pull request
Sep 19, 2016
* ThreadLocal based Inspektr PrincipalResolver * Refactor to fix NPE bug * Polishing based on feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a ThreadLocal based storage for current Authentication object as well as Inspektr PrincipalResolver based on that state. This is in response to already complex and brittle current Joinpoint-based PrincipalResolver that does complex Joinpoint parsing and is very tightly coupled to CAS API which in the latest iterations has changed significantly and therefore this resolver is not able to resolve proper principal at all the configured audit points.
This PR also has the side effect that this ThreadLocal holder for current authentication could be used by other interested downstream components without tight coupling to all the internal CAS components just to get a currently in-progress authentication/principal, should they need it.