New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AuthnContext comparison type is mandatory for AuthnContextClassRef #2794

Merged
merged 2 commits into from Jul 18, 2017

Conversation

Projects
None yet
4 participants
@fmartelli
Contributor

fmartelli commented Jul 17, 2017

This PR introduce a new configuration parameter for AuthnContext comparison type.
This parameter will be used set comparison attribute of the given AuthnContextClassRef. In case of missing value, "exact" comparison type is used.

Provides the possibility to specify AuthnContext comparison type that…
… is mandatory for AuthnContextClassRef
@CLAassistant

This comment has been minimized.

Show comment
Hide comment
@CLAassistant

CLAassistant Jul 17, 2017

CLA assistant check
All committers have signed the CLA.

CLAassistant commented Jul 17, 2017

CLA assistant check
All committers have signed the CLA.

@mmoayyed

This comment has been minimized.

Show comment
Hide comment
@mmoayyed

mmoayyed Jul 17, 2017

Member

Please document the setting, both in the project documentation and in code.

Member

mmoayyed commented Jul 17, 2017

Please document the setting, both in the project documentation and in code.

@fmartelli

This comment has been minimized.

Show comment
Hide comment
@fmartelli

fmartelli Jul 18, 2017

Contributor

Hi Misagh, I think I have addressed your comments (not sure about the documentation).
Please, review and let me know.
Regards

Contributor

fmartelli commented Jul 18, 2017

Hi Misagh, I think I have addressed your comments (not sure about the documentation).
Please, review and let me know.
Regards

@apereo apereo deleted a comment from codacy-bot Jul 18, 2017

@codacy-bot

This comment has been minimized.

Show comment
Hide comment
@codacy-bot

codacy-bot Jul 18, 2017

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- core/cas-server-core-configuration/src/main/java/org/apereo/cas/configuration/model/support/pac4j/Pac4jProperties.java  2
         

See the complete overview on Codacy

codacy-bot commented Jul 18, 2017

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- core/cas-server-core-configuration/src/main/java/org/apereo/cas/configuration/model/support/pac4j/Pac4jProperties.java  2
         

See the complete overview on Codacy

@mmoayyed

This comment has been minimized.

Show comment
Hide comment
@mmoayyed

mmoayyed Jul 18, 2017

Member

Thank you very much for the contribution. Outstanding work. Keep 'em coming!

Member

mmoayyed commented Jul 18, 2017

Thank you very much for the contribution. Outstanding work. Keep 'em coming!

@mmoayyed mmoayyed closed this Jul 18, 2017

@mmoayyed mmoayyed reopened this Jul 18, 2017

@mmoayyed mmoayyed added this to the 5.2.0-RC2 milestone Jul 18, 2017

@mmoayyed mmoayyed merged commit 2b22acf into apereo:master Jul 18, 2017

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
codacy/pr Good work! A positive pull request.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment