CAS-1429 Escape inputs into LDAP filter expressions. #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents LDAP injection attacks.
|
+1 |
|
Maybe a test to check that the characters are properly escaped now would be great... |
|
Good suggestion on test. LDAP tests are notoriously difficult due to lack of a test fixture that provides a directory to test against, but testing encoding may be possible. |
leleuj
added a commit
that referenced
this pull request
Jan 12, 2015
CAS-1429 Escape inputs into LDAP filter expressions.
mmoayyed
pushed a commit
that referenced
this pull request
Sep 19, 2016
CAS-1429 Escape inputs into LDAP filter expressions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents LDAP injection attacks. Note this patch is only relevant for the 3.5.x branch since master is based on ldaptive, which properly handles character escaping.