Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Downgrade Apache Tomcat to 9.0.24 #4288

Merged
merged 3 commits into from Oct 3, 2019

Conversation

@charlibot
Copy link
Contributor

commented Sep 25, 2019

The upgrade of the tomcat version in CAS causes the server to exit with a java.io.IOException: Stream closed when the keystore is attempting to be loaded. Not sure if this is an issue with Tomcat or Springboot's integration with it.

Simply running ./gradlew run on the latest copy cas-overlay-template will demonstrate the issue.

@hdeadman

This comment has been minimized.

Copy link
Member

commented Sep 26, 2019

I think change in Tomcat is breaking things:
apache/tomcat@ccabf8e#diff-6521067992f71bb248d3d60bd65e94f3

Change made due to this: spring-projects/spring-boot#17841

I am debugging to see what is going on.

hdeadman referenced this pull request in apache/tomcat Sep 26, 2019
@hdeadman

This comment has been minimized.

Copy link
Member

commented Sep 26, 2019

@charlibot One hack way to fix overlay short term is to use the exclusion feature of the overlay to exclude the jar with bug and then add in the older version that works:
hdeadman/cas-overlay-template@40672ae
The exclusion may not even be necessary because adding the 9.0.24 version probably gets picked up first. You would be running a mix of Tomcat 9.0.24 and 9.0.26 but it starts up.

Merging this now wouldn't help because I don't think snapshots are going to be published until the CAS unit tests are working again.

There may be other workarounds such as using a keystore path relative to tomcat base (which Tomcat looks for first).

@charlibot

This comment has been minimized.

Copy link
Contributor Author

commented Sep 26, 2019

@hdeadman thanks! Looks like the tomcat fix has already been added so hopefully the next release will resolve this. I'll close this PR

@charlibot charlibot closed this Sep 26, 2019
@mmoayyed

This comment has been minimized.

Copy link
Member

commented Oct 3, 2019

Looks Boot 2.2 RC1 is going to ship with 9.0.26 anyway as they cannot wait for Tomcat 9.0.27. We'll downgrade for now and will pick up the tomcat fix later in a patch release, etc.

@mmoayyed mmoayyed reopened this Oct 3, 2019
@mmoayyed mmoayyed changed the title set springBootTomcatVersion to 9.0.24 (last known working version) Regression: Downgrade Apache Tomcat to 9.0.24 Oct 3, 2019
@mmoayyed mmoayyed merged commit 4ac9946 into apereo:master Oct 3, 2019
3 of 4 checks passed
3 of 4 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Summary 2 potential rules
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details
@mmoayyed

This comment has been minimized.

Copy link
Member

commented Oct 3, 2019

@charlibot thanks very much, for identifying this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.