Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

renovatebot(deps): update dependency org.jasig.cas.client:cas-client-core to v3.6.0 #4331

Merged
merged 3 commits into from Oct 8, 2019

Conversation

@mmoayyed
Copy link
Member

commented Oct 7, 2019

This PR contains the following updates:

Package Update Change
org.jasig.cas.client:cas-client-core minor 3.5.1 -> 3.6.0

Renovate configuration

馃搮 Schedule: At any time (no schedule defined).

馃殾 Automerge: Disabled by config. Please merge this manually once you are satisfied.

鈾伙笍 Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

馃敃 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

鈥re-3.x
@mmoayyed

This comment has been minimized.

Copy link
Member Author

commented Oct 8, 2019

@leleuj is this something you might have time to review?

/home/travis/build/apereo/cas/support/cas-server-support-ws-idp/src/main/java/org/apereo/cas/ws/idp/web/WSFederationValidateRequestController.java:96: error: Cannot use 'val' here because initializer expression does not have a representable type: Type cannot be resolved
        val initialUrl = CommonUtils.constructRedirectUrl(getWsFederationRequestConfigurationContext().getCasProperties().getServer().getLoginUrl(),
@mmoayyed

This comment has been minimized.

Copy link
Member Author

commented Oct 8, 2019

I have released 3.6.1 to remove an API compatibility issue. Patch basically includes an overloaded method without the new method parameter.

@leleuj

This comment has been minimized.

Copy link
Contributor

commented Oct 8, 2019

Indeed, the method signature has changed with the method parameter and it broke things...

@mergify mergify bot merged commit afc8432 into master Oct 8, 2019
5 of 6 checks passed
5 of 6 checks passed
Codacy/PR Quality Review Hang in there, Codacy is reviewing your Pull request.
Details
Summary 2 rules match
Details
Tidelift Dependencies checked
Details
WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@mergify mergify bot deleted the renovate/org.jasig.cas.client-cas-client-core-3.x branch Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.