Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[WIP]: revert change that breaks ssoEnabled when pac4j-webflow configured #4332
This is a workaround to revert a change introduced in 6.1.0-RC4 in the following commit:
that causes certain SAML logins to fail for services when delegated authentication (support-pac4j-webflow) is configured. The mere presence of the support-pac4j-webflow dependency causes the problem, even if no services are configured to use delegated auth.
Simply backing out the change is probably not the real solution (it was presumably there for a reason), but I don't understand the rationale for the change well enough to propose a better fix.
Procedure to reproduce:
Error: Exception thrown in state 'viewLoginForm' of flow 'login'
@@ Coverage Diff @@ ## master #4332 +/- ## ========================================= Coverage ? 39.39% Complexity ? 5138 ========================================= Files ? 1667 Lines ? 37012 Branches ? 3416 ========================================= Hits ? 14580 Misses ? 21036 Partials ? 1396