Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix authn delegation behavior #4643

Merged
merged 1 commit into from Jan 27, 2020
Merged

Fix authn delegation behavior #4643

merged 1 commit into from Jan 27, 2020

Conversation

leleuj
Copy link
Contributor

@leleuj leleuj commented Jan 22, 2020

If we force the authn delegation process on an existing SSO session, the current behavior is unappropriate: the credentials should not be put in the webflow for an existing session as they trigger a login process, erasing the previous authenticated user.

I also changed the visibility of two methods from private to protected for customisation purposes.

@claassistantio
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov
Copy link

codecov bot commented Jan 22, 2020

Codecov Report

Merging #4643 into 6.1.x will increase coverage by 13.09%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##              6.1.x    #4643       +/-   ##
=============================================
+ Coverage     32.75%   45.84%   +13.09%     
- Complexity     5210     7662     +2452     
=============================================
  Files          2579     2579               
  Lines         52522    52506       -16     
  Branches       4176     4174        -2     
=============================================
+ Hits          17204    24073     +6869     
+ Misses        33994    26562     -7432     
- Partials       1324     1871      +547
Impacted Files Coverage Δ Complexity Δ
.../web/flow/DelegatedClientAuthenticationAction.java 53.84% <ø> (+53.84%) 21 <0> (+21) ⬆️
...org/apereo/cas/couchdb/tickets/TicketDocument.java 0% <0%> (-100%) 0% <0%> (-1%)
...g/apereo/cas/services/DynamoDbServiceRegistry.java 0% <0%> (-100%) 0% <0%> (-7%)
...DbMultifactorAuthenticationTrustConfiguration.java 0% <0%> (-100%) 0% <0%> (-4%)
...o/cas/monitor/config/LdapMonitorConfiguration.java 0% <0%> (-100%) 0% <0%> (-3%)
...icket/refreshtoken/OAuth20DefaultRefreshToken.java 0% <0%> (-100%) 0% <0%> (-3%)
...org/apereo/cas/audit/CouchDbAuditTrailManager.java 0% <0%> (-100%) 0% <0%> (-4%)
...s/config/MemcachedTicketRegistryConfiguration.java 0% <0%> (-100%) 0% <0%> (-5%)
...nfig/SurrogateLdapAuthenticationConfiguration.java 0% <0%> (-100%) 0% <0%> (-3%)
...apereo/cas/config/CouchDbYubiKeyConfiguration.java 0% <0%> (-100%) 0% <0%> (-6%)
... and 1232 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b156ed1...a4764df. Read the comment docs.

@mmoayyed mmoayyed merged commit f7f9d93 into apereo:6.1.x Jan 27, 2020
@leleuj leleuj deleted the authdelegate-61x branch January 27, 2020 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants