Make it easier to create a new RegisteredService implementation #6

Merged
merged 3 commits into from Mar 7, 2012

Conversation

Projects
None yet
3 participants
Member

frett commented Oct 12, 2011

I need to track a couple additional flags with the RegisteredService object and would like to utilize as much of the existing RegisteredServiceImpl framework as possible.

These commits make it easier to create a new implementation of RegisteredService and utilize several existing objects for management of RegisteredServices.

frett added some commits Oct 12, 2011

@frett frett Make it easier to override clone in subclasses
created the cloned object using the class of the sourced object to allow
classes that extend RegisteredServiceImpl to only need to track their
own attributes in the clone method
df298d8
@frett frett Update the supports method to support any implementation 3e11ee5
@frett frett Utilize the underlying createCommand method
This change will allow the command class to be overridden to support
subclasses of RegisteredServiceImpl
f0c242b
Contributor

battags commented Oct 13, 2011

Hi,

Can you open a JIRA issue for this?

Thanks!
Scott

Member

frett commented Oct 13, 2011

opened a JIRA issue here: https://issues.jasig.org/browse/CAS-1056

Contributor

apetro commented Oct 14, 2011

These look like fine improvements. I have customized FancyRegisteredServiceImpls in some CAS customizations I did for a client, and while it didn't occur to me to extend RegisteredServiceImpl, if I had tried that I would have benefited from these changes.

@apetro apetro added a commit that referenced this pull request Mar 7, 2012

@apetro apetro Merge pull request #6 from frett/extendRegisteredService
Make it easier to create a new RegisteredService implementation
494b05e

@apetro apetro merged commit 494b05e into apereo:master Mar 7, 2012

@mmoayyed mmoayyed added a commit that referenced this pull request May 24, 2015

@mmoayyed mmoayyed Merge pull request #6 from seanrbaker/spnego-target-systems
Updates
92aa156

@mmoayyed mmoayyed added a commit that referenced this pull request Aug 17, 2015

@mmoayyed mmoayyed Merge pull request #18 from doodelicious/mgmt-webapp
#1, #4, #6, and #9: Services list direction icons, tooltip messages…
da80629
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment