GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
I need to track a couple additional flags with the RegisteredService object and would like to utilize as much of the existing RegisteredServiceImpl framework as possible.
These commits make it easier to create a new implementation of RegisteredService and utilize several existing objects for management of RegisteredServices.
Make it easier to override clone in subclasses
created the cloned object using the class of the sourced object to allow
classes that extend RegisteredServiceImpl to only need to track their
own attributes in the clone method
Update the supports method to support any implementation
Utilize the underlying createCommand method
This change will allow the command class to be overridden to support
subclasses of RegisteredServiceImpl
Can you open a JIRA issue for this?
opened a JIRA issue here: https://issues.jasig.org/browse/CAS-1056
These look like fine improvements. I have customized FancyRegisteredServiceImpls in some CAS customizations I did for a client, and while it didn't occur to me to extend RegisteredServiceImpl, if I had tried that I would have benefited from these changes.
Merge pull request #6 from frett/extendRegisteredService
Make it easier to create a new RegisteredService implementation
Merge pull request #6 from seanrbaker/spnego-target-systems
Merge pull request #18 from doodelicious/mgmt-webapp
#1, #4, #6, and #9: Services list direction icons, tooltip messages…