Fix coding style of phpcas #14

Closed
jfritschi opened this Issue Dec 11, 2011 · 5 comments

Comments

Projects
None yet
2 participants
Contributor

jfritschi commented Dec 11, 2011

Running phpcs on phpcas has show a lot of coding style deficiencies. They should be corrected so that we can work on becoming a PEAR package at some point.

jfritschi added a commit that referenced this issue Dec 11, 2011

Contributor

jfritschi commented Dec 11, 2011

I have added the first few commits of style fixes and will go through all files over the next few days. The changes are all just documentation, naming standards and indentation.

@ghost ghost assigned jfritschi Dec 11, 2011

Contributor

saltybeagle commented Dec 12, 2011

Looking good.

jfritschi added a commit that referenced this issue Dec 20, 2011

jfritschi added a commit that referenced this issue Dec 20, 2011

jfritschi added a commit that referenced this issue Dec 20, 2011

Contributor

jfritschi commented Dec 20, 2011

I did a lot more refactoring and style correction. I have also tried to fix the @author tags for all major contributors. Any comments or suggestions are welcome.

The only outstanding errors are in the Client.php class and /test. They will be fixed in the next few days.

I have not yet bothered to fix warning on a global level. Maybe later ;)

jfritschi added a commit that referenced this issue Jan 2, 2012

jfritschi added a commit that referenced this issue Jan 2, 2012

frett pushed a commit to frett/phpCAS that referenced this issue Jan 9, 2012

adamfranco added a commit that referenced this issue Jan 10, 2012

#14 Add the test/ directory to the include path so unit tests can run.
After the explicit require_once lines were removed in fffb763 the unit tests
couldn't find the CAS_TestHarness_DummyRequest class.

jfritschi added a commit that referenced this issue Jan 15, 2012

jfritschi added a commit that referenced this issue Jan 15, 2012

Contributor

jfritschi commented Jan 21, 2012

I think i'm pretty much done with most of the changes

There is only one outstanding error: The naming of the main class "phpCAS" does not conform to the PEAR naming standard but that would be a heavy api change and can't be part of 1.3 anyway.

So we are down to 1 ERROR and ~400 Warning due to being over 85 chars in a single. Nothing major bot very tedious manual work which i will continue to work on over the next few days and weeks.

Contributor

jfritschi commented Feb 2, 2012

Closing this issue and i'm opening an new issue for the warnings.

@jfritschi jfritschi closed this Feb 2, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment