Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't treat setDF failed as error #2

Merged
merged 1 commit into from
May 16, 2022
Merged

don't treat setDF failed as error #2

merged 1 commit into from
May 16, 2022

Conversation

haruue
Copy link
Collaborator

@haruue haruue commented May 15, 2022

setDF() raised this error and made hysteria fully stop working on Windows 7
apernet/hysteria#327

I tested and seems like ignoring this error won't cause other problems.

And this error handle itself is really weird:

  • IPv4 setDF failed => ok
  • IPv6 setDF failed => ok
  • IPv4 setDF failed && IPv6 setDF failed => raise err (why?)

@codecov-commenter
Copy link

codecov-commenter commented May 15, 2022

Codecov Report

Merging #2 (48248ae) into v0.27.0-mod (ed2a645) will not change coverage.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##           v0.27.0-mod       #2   +/-   ##
============================================
  Coverage        85.35%   85.35%           
============================================
  Files              138      138           
  Lines             9918     9918           
============================================
  Hits              8465     8465           
  Misses            1072     1072           
  Partials           381      381           
Impacted Files Coverage Δ
sys_conn_df_linux.go 52.94% <0.00%> (ø)
sys_conn_df_windows.go 52.94% <0.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@tobyxdd tobyxdd merged commit 503ec23 into apernet:v0.27.0-mod May 16, 2022
tobyxdd added a commit that referenced this pull request May 16, 2022
don't treat setDF failed as error

(cherry picked from commit 503ec23)
@haruue haruue deleted the v0.27.0-mod branch May 16, 2022 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants