Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resizing window resets translation textarea heights #151

Open
sushain97 opened this issue Jun 19, 2017 · 13 comments
Open

Resizing window resets translation textarea heights #151

sushain97 opened this issue Jun 19, 2017 · 13 comments
Assignees

Comments

@sushain97
Copy link
Member

I really want it to retain my heights. Resetting them to whatever the app wants is silly and I'm not sure when this bad behavior creeped in.

@share-with-me perhaps this can be fixed with #142?

@share-with-me
Copy link
Contributor

That means, when the window is resized, synchronizeTextareaHeights should not be called? That is, the heights of the textareas should stay the same even on resizing?

@sushain97
Copy link
Member Author

I don't know exactly what synchronizeTextareaHeights does. But that sounds like a reasonable conclusion. Can you figure out why it was made to do that? git blame might be helpful.

@share-with-me
Copy link
Contributor

share-with-me commented Jun 19, 2017

On it!

@share-with-me
Copy link
Contributor

share-with-me commented Jun 19, 2017

I really want it to retain my heights.

Um, do you mean in the event that I manually resize it using the dragger at the bottom right? Because currently, when I paste in a lot of content, the textarea dynamically resizes itself and retains its height even on window resize!

@sushain97
Copy link
Member Author

Um, do you mean in the event that I manually resize it using the dragger at the bottom right?

Yes.

On it! Meanwhile could you please review the comments on #142 ?! Thanks!

I'll take a look when I'm free. I think this issue and that one are connected/can be solved together.

@share-with-me
Copy link
Contributor

I'll take a look when I'm free. I think this issue and that one are connected/can be solved together.

Thanks :D

@sushain97
Copy link
Member Author

Assigning to myself since #152 is blocked by me figuring out sane requirements.

@Androbin
Copy link
Contributor

Any updates on this yet?

@sushain97
Copy link
Member Author

No. If you would like to figure out the prons and cons of each approach, feel free!

@Androbin
Copy link
Contributor

Well, for one thing, I could resolve #152.

@sushain97
Copy link
Member Author

I don't know what it means to resolve a pull request.

The blocking item here is that the correct behavior for each scenario needs to be articulated. See my comments here and on #132 and #152 for different problems I've brought up.

@Androbin
Copy link
Contributor

I don't know what it means to resolve a pull request.

I meant resolving the merge conflicts and addressing the issues brought up.

@sushain97
Copy link
Member Author

I would rather nothing happen until a solid plan is formed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants