Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QUnit testing framework #268

Open
wants to merge 14 commits into
base: master
from
Open

QUnit testing framework #268

wants to merge 14 commits into from

Conversation

@JPJPJPOPOP
Copy link
Contributor

JPJPJPOPOP commented Jan 15, 2018

cc @sushain97. Tried my best at this task, and got the baseline framework down.

This provides the testing framework for QUnit. You can access in-browser testing at qunit-test.html and run tests via CLI with grunt qunit.

All testing files added to tests/ will run correctly in the browser, which you can access through qunit-test.html. However, the tests may differ from in-browser using the CLI with grunt qunit. Still trying to debug this issue, but ALL tests run in-browser work and are accurate.

Fixes #116.

JPJPJPOPOP added 3 commits Jan 15, 2018
This is because phantomJS, where we run our
continuous integration tests for QUnit, isn't on
ES6. This is the simple fix without importing other
packages.
tests/a.js Outdated
@@ -0,0 +1,5 @@
QUnit.module( "test" );
QUnit.test( "sample test 1", function (assert) {
assert.equal(4, 2+2);

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Jan 15, 2018

No magic number: 4 no-magic-numbers
Infix operators must be spaced space-infix-ops

tests/a.js Outdated
@@ -0,0 +1,5 @@
QUnit.module( "test" );
QUnit.test( "sample test 1", function (assert) {

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Jan 15, 2018

'QUnit' is not defined no-undef
There should be no spaces inside this paren space-in-parens
Strings must use singlequote quotes

tests/a.js Outdated
@@ -0,0 +1,5 @@
QUnit.module( "test" );

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Jan 15, 2018

'QUnit' is not defined no-undef
There should be no spaces inside this paren space-in-parens
Strings must use singlequote quotes

all: "build/qunit-test.html"
}
} );
grunt.loadNpmTasks( "grunt-contrib-qunit" );

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Jan 15, 2018

There should be no spaces inside this paren space-in-parens
Strings must use singlequote quotes

qunit: {
all: "build/qunit-test.html"
}
} );

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Jan 15, 2018

There should be no spaces inside this paren space-in-parens

module.exports = function( grunt ) {
grunt.initConfig( {
qunit: {
all: "build/qunit-test.html"

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Jan 15, 2018

Identifier name 'all' is too short (< 4) id-length
Strings must use singlequote quotes

@@ -0,0 +1,8 @@
module.exports = function( grunt ) {
grunt.initConfig( {

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Jan 15, 2018

There should be no spaces inside this paren space-in-parens

@@ -0,0 +1,8 @@
module.exports = function( grunt ) {

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Jan 15, 2018

'module' is not defined no-undef
There should be no spaces inside this paren space-in-parens
Missing space before function parentheses space-before-function-paren

@shardulc

This comment has been minimized.

Copy link
Member

shardulc commented Jan 15, 2018

Hound probably needs different config rules for the Gruntfile and the tests?

tests/a.js Outdated
@@ -0,0 +1,5 @@
QUnit.module('test');
QUnit.test('sample test 1', function (assert) {
assert.equal(4, 2+2);

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Jan 15, 2018

No magic number: 4 no-magic-numbers
Infix operators must be spaced space-infix-ops

tests/a.js Outdated
@@ -0,0 +1,5 @@
QUnit.module('test');
QUnit.test('sample test 1', function (assert) {

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Jan 15, 2018

'QUnit' is not defined no-undef

tests/a.js Outdated
@@ -0,0 +1,5 @@
QUnit.module('test');

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Jan 15, 2018

'QUnit' is not defined no-undef

tests/a.js Outdated
@@ -0,0 +1,5 @@
QUnit.module('test');
QUnit.test('sample test 1', function (assert) {
assert.equal(4, 2+2);

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Jan 15, 2018

No magic number: 4 no-magic-numbers
Infix operators must be spaced space-infix-ops

tests/a.js Outdated
@@ -0,0 +1,5 @@
QUnit.module('test');
QUnit.test('sample test 1', function (assert) {

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Jan 15, 2018

'QUnit' is not defined no-undef

tests/a.js Outdated
@@ -0,0 +1,5 @@
QUnit.module('test');

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Jan 15, 2018

'QUnit' is not defined no-undef

@sushain97

This comment has been minimized.

Copy link
Member

sushain97 commented Jan 15, 2018

Just make Hound ignore the tests folder? I don't think there's a way to configure different rulesets. Some of the errors should be fixed though.

Copy link
Member

sushain97 left a comment

Looks like a good start! Excited to see a real test ;)

@@ -8,7 +8,9 @@ jobs:

# Install development dependencies
- run: sudo apt-get install python3 python3-pip
- run: sudo npm install -g jsonlint eslint flow flow-bin flow-coverage-report htmlhint sass-lint
- run: sudo npm install -g jsonlint eslint flow flow-bin flow-coverage-report htmlhint sass-lint grunt-cli

This comment has been minimized.

Copy link
@sushain97

sushain97 Jan 15, 2018

Member

We should just have a package.json at this point.

This comment has been minimized.

Copy link
@JPJPJPOPOP

JPJPJPOPOP Jan 17, 2018

Author Contributor

@sushain97 I tried for several hours to try to get this to work, but I was unable to do this. I don't exactly know, but it might be because of the -g, and apparently installing “global” npm dependencies via package.json isn't supported? I created the package.json and was running npm install, but I kept on getting No such file or directory.

@@ -23,6 +25,9 @@ jobs:
# Build project
- run: cp config.conf.example config.conf
- run: make -j8 || true

# Run unit tests
- run: grunt qunit

This comment has been minimized.

Copy link
@sushain97

sushain97 Jan 15, 2018

Member

Move this up to with the run tests block.

This comment has been minimized.

Copy link
@JPJPJPOPOP

JPJPJPOPOP Jan 15, 2018

Author Contributor

This has to be done after make -j8 is called.

This comment has been minimized.

Copy link
@sushain97

sushain97 Jan 15, 2018

Member

Fair, then let's move the make stuff up.

Makefile Outdated
@@ -5,13 +5,13 @@ all: check-deps prod

debug: debugjs debugcss build/index.debug.html build/not-found.html fonts build/js/compat.js build/js/jquery.min.js build/js/bootstrap.min.js build/sitemap.xml build/strings/locales.json build/index.$(DEFAULT_LOCALE).html build/strings/$(DEFAULT_LOCALE).json images

prod: js css html fonts build/sitemap.xml build/manifest.json build/strings/locales.json localhtml images
prod: js css html fonts build/sitemap.xml build/manifest.json build/strings/locales.json localhtml images tests

This comment has been minimized.

Copy link
@sushain97

sushain97 Jan 15, 2018

Member

No, this doesn't sound good. We should have a test target, a la make test.

@@ -100,7 +100,7 @@ $(document).ready(function () {

var pathname /*: string */ = window.location.pathname;

if(window.history.replaceState && !pathname.endsWith('/index.debug.html')) {
if(window.history.replaceState && !(pathname.indexOf('/index.debug.html') === pathname.length - '/index.debug.html'.length)) {

This comment has been minimized.

Copy link
@sushain97

sushain97 Jan 15, 2018

Member

what's going on here?

This comment has been minimized.

Copy link
@JPJPJPOPOP

JPJPJPOPOP Jan 15, 2018

Author Contributor

@sushain97 This is because phantomJS, where we run our continuous integration tests for QUnit, isn't on ES6. This is the simple fix without importing other packages.

This comment has been minimized.

Copy link
@sushain97

sushain97 Jan 15, 2018

Member

Doesn't compat.js have shims? It could be included in the test head to fix it.

@@ -44,7 +44,7 @@ Store.prototype.set = function /*:: <T> */ (key /*: string */, value /*: T */) /
Store.prototype.clear = function () /*: void */ {
if(this.able()) {
for(var key in window.localStorage) {
if(key.startsWith((this.prefix /*: string */))) {
if(key.indexOf((this.prefix /*: string */)) === 0) {

This comment has been minimized.

Copy link
@sushain97

sushain97 Jan 15, 2018

Member

startsWith is much nicer?? why change this (and the other instances)

@@ -58,6 +59,7 @@
<link rel="manifest" href="./manifest.json">
</head>
<body>
<!-- qunit-testing -->

This comment has been minimized.

Copy link
@sushain97

sushain97 Jan 15, 2018

Member

quint-tests?

@@ -31,6 +31,7 @@

<!--[if lt IE 9]> <script type="text/javascript" src="./js/compat.js"></script> <![endif]-->
@include_head@
<!-- qunit head -->

This comment has been minimized.

Copy link
@sushain97

sushain97 Jan 15, 2018

Member

qunit-head? I'm hoping this only happens with make test, we don't need everyone running tests ;)

This comment has been minimized.

Copy link
@JPJPJPOPOP

JPJPJPOPOP Jan 17, 2018

Author Contributor

@sushain97 The <!-- qunit head --> and <!-- qunit-tests -->only get injected when running on qunit-test.html.

@JPJPJPOPOP JPJPJPOPOP force-pushed the JPJPJPOPOP:qunit branch from b5dd38f to a362a08 Jan 17, 2018
@apertium apertium deleted a comment from houndci-bot Jan 18, 2018
@apertium apertium deleted a comment from houndci-bot Jan 18, 2018
@apertium apertium deleted a comment from houndci-bot Jan 18, 2018
@apertium apertium deleted a comment from houndci-bot Jan 18, 2018
sushain97 added 2 commits Jan 18, 2018
tests/a.js Outdated
@@ -0,0 +1,23 @@
/* eslint-disable */

This comment has been minimized.

Copy link
@sushain97

sushain97 Jan 18, 2018

Member

Why? There are a number of stylistic concerns here.



<!-- add test files here -->
<script type="text/javascript" src="./tests/a.js"></script>

This comment has been minimized.

Copy link
@sushain97
# Build project
- run: cp config.conf.example config.conf
- run: make -j8 || true
- run: grunt qunit

This comment has been minimized.

Copy link
@sushain97

sushain97 Jan 18, 2018

Member

make test never gets run?

This comment has been minimized.

Copy link
@JPJPJPOPOP

JPJPJPOPOP Jan 18, 2018

Author Contributor

@sushain97 did you want make to not create test files and make test to create test files?

This comment has been minimized.

Copy link
@sushain97

sushain97 Jan 18, 2018

Member

Seems sensible?

This comment has been minimized.

Copy link
@JPJPJPOPOP

JPJPJPOPOP Jan 18, 2018

Author Contributor

In other words, currently make test works to create test files. However, make will always build all files for you including test files.

This comment has been minimized.

Copy link
@JPJPJPOPOP

JPJPJPOPOP Jan 18, 2018

Author Contributor

@sushain97 Ahh oops, I realized what I did wrong :D

assert.equal( config.ENABLED_MODES.includes('translation'), modeEnabled('translation'), 'Translation mode is consistent' );
assert.equal( config.ENABLED_MODES.includes('generation'), modeEnabled('generation'), 'Generation mode is consistent' );
assert.equal( config.ENABLED_MODES.includes('analyzation'), modeEnabled('analyzation'), 'Analyzation mode is consistent' );
assert.equal( config.ENABLED_MODES.includes('sandbox'), modeEnabled('sandbox'), 'Sandbox mode is consistent' );

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Jan 18, 2018

Expected indentation of 4 spaces but found 3 indent
There should be no spaces inside this paren space-in-parens
'config' is not defined no-undef
'modeEnabled' is not defined no-undef

assert.expect( 4 );
assert.equal( config.ENABLED_MODES.includes('translation'), modeEnabled('translation'), 'Translation mode is consistent' );
assert.equal( config.ENABLED_MODES.includes('generation'), modeEnabled('generation'), 'Generation mode is consistent' );
assert.equal( config.ENABLED_MODES.includes('analyzation'), modeEnabled('analyzation'), 'Analyzation mode is consistent' );

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Jan 18, 2018

Expected indentation of 4 spaces but found 3 indent
There should be no spaces inside this paren space-in-parens
'config' is not defined no-undef
'modeEnabled' is not defined no-undef

QUnit.test( 'Check modeEnabled', function ( assert ) {
assert.expect( 4 );
assert.equal( config.ENABLED_MODES.includes('translation'), modeEnabled('translation'), 'Translation mode is consistent' );
assert.equal( config.ENABLED_MODES.includes('generation'), modeEnabled('generation'), 'Generation mode is consistent' );

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Jan 18, 2018

Expected indentation of 4 spaces but found 3 indent
There should be no spaces inside this paren space-in-parens
'config' is not defined no-undef
'modeEnabled' is not defined no-undef

QUnit.module( 'Verify modeEnabled is consistent with config file' );
QUnit.test( 'Check modeEnabled', function ( assert ) {
assert.expect( 4 );
assert.equal( config.ENABLED_MODES.includes('translation'), modeEnabled('translation'), 'Translation mode is consistent' );

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Jan 18, 2018

Expected indentation of 4 spaces but found 3 indent
There should be no spaces inside this paren space-in-parens
'config' is not defined no-undef
'modeEnabled' is not defined no-undef


QUnit.module( 'Verify modeEnabled is consistent with config file' );
QUnit.test( 'Check modeEnabled', function ( assert ) {
assert.expect( 4 );

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Jan 18, 2018

Expected indentation of 4 spaces but found 3 indent
There should be no spaces inside this paren space-in-parens
No magic number: 4 no-magic-numbers

$( 'a[data-mode="sandbox"]' ).click();
assert.equal( $('#sandboxContainer').css('display'), 'block', 'Switching to sandbox mode' );
$( 'a[data-mode="translation"]' ).click();
assert.equal( $('#translationContainer').css('display'), 'block', 'Switching to translation mode' );

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Jan 18, 2018

There should be no spaces inside this paren space-in-parens

assert.expect( 4 );
$( 'a[data-mode="sandbox"]' ).click();
assert.equal( $('#sandboxContainer').css('display'), 'block', 'Switching to sandbox mode' );
$( 'a[data-mode="translation"]' ).click();

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Jan 18, 2018

There should be no spaces inside this paren space-in-parens

QUnit.test( 'Mode test', function ( assert ) {
assert.expect( 4 );
$( 'a[data-mode="sandbox"]' ).click();
assert.equal( $('#sandboxContainer').css('display'), 'block', 'Switching to sandbox mode' );

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Jan 18, 2018

There should be no spaces inside this paren space-in-parens

QUnit.module( 'Change mode' );
QUnit.test( 'Mode test', function ( assert ) {
assert.expect( 4 );
$( 'a[data-mode="sandbox"]' ).click();

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Jan 18, 2018

There should be no spaces inside this paren space-in-parens

@@ -0,0 +1,21 @@
QUnit.module( 'Change mode' );
QUnit.test( 'Mode test', function ( assert ) {
assert.expect( 4 );

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Jan 18, 2018

There should be no spaces inside this paren space-in-parens
No magic number: 4 no-magic-numbers

assert.equal( config.ENABLED_MODES.includes('translation'), modeEnabled('translation'), 'Translation mode is consistent' );
assert.equal( config.ENABLED_MODES.includes('generation'), modeEnabled('generation'), 'Generation mode is consistent' );
assert.equal( config.ENABLED_MODES.includes('analyzation'), modeEnabled('analyzation'), 'Analyzation mode is consistent' );
assert.equal( config.ENABLED_MODES.includes('sandbox'), modeEnabled('sandbox'), 'Sandbox mode is consistent' );

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Jan 18, 2018

Expected indentation of 4 spaces but found 3 indent
There should be no spaces inside this paren space-in-parens
'config' is not defined no-undef
'modeEnabled' is not defined no-undef

assert.expect( 4 );
assert.equal( config.ENABLED_MODES.includes('translation'), modeEnabled('translation'), 'Translation mode is consistent' );
assert.equal( config.ENABLED_MODES.includes('generation'), modeEnabled('generation'), 'Generation mode is consistent' );
assert.equal( config.ENABLED_MODES.includes('analyzation'), modeEnabled('analyzation'), 'Analyzation mode is consistent' );

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Jan 18, 2018

Expected indentation of 4 spaces but found 3 indent
There should be no spaces inside this paren space-in-parens
'config' is not defined no-undef
'modeEnabled' is not defined no-undef

QUnit.test( 'Check modeEnabled', function ( assert ) {
assert.expect( 4 );
assert.equal( config.ENABLED_MODES.includes('translation'), modeEnabled('translation'), 'Translation mode is consistent' );
assert.equal( config.ENABLED_MODES.includes('generation'), modeEnabled('generation'), 'Generation mode is consistent' );

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Jan 18, 2018

Expected indentation of 4 spaces but found 3 indent
There should be no spaces inside this paren space-in-parens
'config' is not defined no-undef
'modeEnabled' is not defined no-undef

QUnit.module( 'Verify modeEnabled is consistent with config file' );
QUnit.test( 'Check modeEnabled', function ( assert ) {
assert.expect( 4 );
assert.equal( config.ENABLED_MODES.includes('translation'), modeEnabled('translation'), 'Translation mode is consistent' );

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Jan 18, 2018

Expected indentation of 4 spaces but found 3 indent
There should be no spaces inside this paren space-in-parens
'config' is not defined no-undef
'modeEnabled' is not defined no-undef


QUnit.module( 'Verify modeEnabled is consistent with config file' );
QUnit.test( 'Check modeEnabled', function ( assert ) {
assert.expect( 4 );

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Jan 18, 2018

Expected indentation of 4 spaces but found 3 indent
There should be no spaces inside this paren space-in-parens
No magic number: 4 no-magic-numbers

$( 'a[data-mode="sandbox"]' ).click();
assert.equal( $('#sandboxContainer').css('display'), 'block', 'Switching to sandbox mode' );
$( 'a[data-mode="translation"]' ).click();
assert.equal( $('#translationContainer').css('display'), 'block', 'Switching to translation mode' );

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Jan 18, 2018

There should be no spaces inside this paren space-in-parens

assert.expect( 4 );
$( 'a[data-mode="sandbox"]' ).click();
assert.equal( $('#sandboxContainer').css('display'), 'block', 'Switching to sandbox mode' );
$( 'a[data-mode="translation"]' ).click();

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Jan 18, 2018

There should be no spaces inside this paren space-in-parens

QUnit.test( 'Mode test', function ( assert ) {
assert.expect( 4 );
$( 'a[data-mode="sandbox"]' ).click();
assert.equal( $('#sandboxContainer').css('display'), 'block', 'Switching to sandbox mode' );

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Jan 18, 2018

There should be no spaces inside this paren space-in-parens

QUnit.module( 'Change mode' );
QUnit.test( 'Mode test', function ( assert ) {
assert.expect( 4 );
$( 'a[data-mode="sandbox"]' ).click();

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Jan 18, 2018

There should be no spaces inside this paren space-in-parens

@@ -0,0 +1,21 @@
QUnit.module( 'Change mode' );
QUnit.test( 'Mode test', function ( assert ) {
assert.expect( 4 );

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Jan 18, 2018

There should be no spaces inside this paren space-in-parens
No magic number: 4 no-magic-numbers

JPJPJPOPOP added 2 commits Jan 18, 2018
assert.equal(config.ENABLED_MODES.includes('translation'), modeEnabled('translation'), 'Translation mode is consistent');
assert.equal(config.ENABLED_MODES.includes('generation'), modeEnabled('generation'), 'Generation mode is consistent');
assert.equal(config.ENABLED_MODES.includes('analyzation'), modeEnabled('analyzation'), 'Analyzation mode is consistent');
assert.equal(config.ENABLED_MODES.includes('sandbox'), modeEnabled('sandbox'), 'Sandbox mode is consistent');

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Jan 18, 2018

'config' is not defined no-undef
'modeEnabled' is not defined no-undef

assert.expect(4);
assert.equal(config.ENABLED_MODES.includes('translation'), modeEnabled('translation'), 'Translation mode is consistent');
assert.equal(config.ENABLED_MODES.includes('generation'), modeEnabled('generation'), 'Generation mode is consistent');
assert.equal(config.ENABLED_MODES.includes('analyzation'), modeEnabled('analyzation'), 'Analyzation mode is consistent');

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Jan 18, 2018

'config' is not defined no-undef
'modeEnabled' is not defined no-undef

QUnit.test('Check modeEnabled', function (assert) {
assert.expect(4);
assert.equal(config.ENABLED_MODES.includes('translation'), modeEnabled('translation'), 'Translation mode is consistent');
assert.equal(config.ENABLED_MODES.includes('generation'), modeEnabled('generation'), 'Generation mode is consistent');

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Jan 18, 2018

'config' is not defined no-undef
'modeEnabled' is not defined no-undef

QUnit.module('Verify modeEnabled is consistent with config file');
QUnit.test('Check modeEnabled', function (assert) {
assert.expect(4);
assert.equal(config.ENABLED_MODES.includes('translation'), modeEnabled('translation'), 'Translation mode is consistent');

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Jan 18, 2018

'config' is not defined no-undef
'modeEnabled' is not defined no-undef


QUnit.module('Verify modeEnabled is consistent with config file');
QUnit.test('Check modeEnabled', function (assert) {
assert.expect(4);

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Jan 18, 2018

No magic number: 4 no-magic-numbers

@@ -0,0 +1,21 @@
QUnit.module('Change mode');
QUnit.test('Mode test', function (assert) {
assert.expect(4);

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Jan 18, 2018

No magic number: 4 no-magic-numbers

@apertium apertium deleted a comment from houndci-bot Jan 18, 2018
@apertium apertium deleted a comment from houndci-bot Jan 18, 2018
@apertium apertium deleted a comment from houndci-bot Jan 18, 2018
@apertium apertium deleted a comment from houndci-bot Jan 18, 2018
assert.equal(config.ENABLED_MODES.includes('translation'), modeEnabled('translation'), 'Translation mode is consistent');
assert.equal(config.ENABLED_MODES.includes('generation'), modeEnabled('generation'), 'Generation mode is consistent');
assert.equal(config.ENABLED_MODES.includes('analyzation'), modeEnabled('analyzation'), 'Analyzation mode is consistent');
assert.equal(config.ENABLED_MODES.includes('sandbox'), modeEnabled('sandbox'), 'Sandbox mode is consistent');

This comment has been minimized.

Copy link
@sushain97

sushain97 Jan 18, 2018

Member

How does this test pass? sandbox isn't enabled in the default configuration...

This comment has been minimized.

Copy link
@JPJPJPOPOP

JPJPJPOPOP Jan 18, 2018

Author Contributor

@sushain97 Not exactly sure what you mean. It should pass, because both would be false then.

# Build project
- run: cp config.conf.example config.conf
- run: make -j8 || true
- run: make test

This comment has been minimized.

Copy link
@sushain97

sushain97 Jan 21, 2018

Member

Seems like make test is a superset of make, i.e. these could be combined?

grunt.initConfig({
qunit: {
all: 'build/qunit-test.html'
}

This comment has been minimized.

Copy link
@sushain97

sushain97 Jan 21, 2018

Member

missing trailing commas

@@ -0,0 +1,10 @@
/* eslint-disable */

module.exports = function(grunt) {

This comment has been minimized.

Copy link
@sushain97

sushain97 Jan 21, 2018

Member

space between function and (?

@JPJPJPOPOP JPJPJPOPOP force-pushed the JPJPJPOPOP:qunit branch from 42983d5 to 452bff6 Jan 21, 2018
@sushain97

This comment has been minimized.

Copy link
Member

sushain97 commented Jan 21, 2018

Hound should be disabled for the Gruntfile?

@JPJPJPOPOP

This comment has been minimized.

Copy link
Contributor Author

JPJPJPOPOP commented Jan 21, 2018

@sushain97 I took out the disable temporarily to see if there were any other formatting issues that I may have missed :D, forgot to add back before pushing

@apertium apertium deleted a comment from houndci-bot Mar 25, 2018
@apertium apertium deleted a comment from houndci-bot Mar 25, 2018
@apertium apertium deleted a comment from houndci-bot Mar 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.