Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for Anaphora Resolution #55

Merged
merged 12 commits into from Aug 13, 2019

Conversation

@khannatanmai
Copy link
Member

commented Aug 12, 2019

These changes are made to add a side "ref" to a Lexical Unit and to make it possible to clip side ref.

The apertium-anaphora module adds the antecedent for an anaphor on the side ref and in transfer, the output word is changed based on the antecedent in side "ref" and hence we need to add the ability to clip side ref.

Copy link
Member

left a comment

It looks fine to me, but perhaps @unhammer could also take a look?

@TinoDidriksen TinoDidriksen merged commit 8903576 into master Aug 13, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@unhammer

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

LGTM.

(I was about to ask what about the cases where preBilingual==false in

else // neither useBilingual nor preBilingual (sl==tl)
and
if(useBilingual && preBilingual == false)
but then http://wiki.apertium.org/wiki/Anaphora_Resolution_Module does say that the anaphora module has to be after lexical selection which implies that apertium-transfer is used with -b . Maybe http://wiki.apertium.org/wiki/Anaphora_Resolution_Module#Anaphora_Resolution_in_Apertium should have some explicit command line examples though, $ echo '^foo/bar/ref$ ^…$' | apertium-stuff + what the output is, and some example lines from modes.xml)

@khannatanmai

This comment has been minimized.

Copy link
Member Author

commented Aug 13, 2019

@unhammer I was wondering what to do there but like you said, it has to be after LexSel so I simply sent an empty ref string to TransferWord, as there really didn't seem to be another option.

I'm not sure exactly what command line examples do you want me to put?

@unhammer

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

Your docs have examples of command line input and output, but not of the commands used, $ apertium-transfer -b foo.t1x foo.t1x.bin < input.txt and similar

@khannatanmai

This comment has been minimized.

Copy link
Member Author

commented Aug 13, 2019

@unhammer does this README have what you're looking for?
https://github.com/apertium/apertium-anaphora/blob/master/README

@unhammer

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

I meant similar to how http://wiki.apertium.org/wiki/A_long_introduction_to_transfer_rules#Lexical_transfer shows inputs, outputs and invocations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.