Installing Node.js dependencies in node_modules can't be deployed #143

Closed
rowanu opened this Issue Jan 25, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@rowanu

rowanu commented Jan 25, 2016

Before Apex I have been installing my Node.js function's dependencies using npm (i.e. in node_modules).

If I try to deploy a function that has a node_modules directory in it, I get the following error:

⨯ error: open functions/ohai/node_modules/node-feedparser/node_modules/lodash/collection/select.js: too many open files

Is this something that should/will be possible? Or am I doing Apex wrong?

@rowanu rowanu changed the title from Installing Node.js dependencies in node_modules to Installing Node.js dependencies in node_modules can't be deployed Jan 25, 2016

@mthenw mthenw added the bug label Jan 25, 2016

@mthenw

This comment has been minimized.

Show comment
Hide comment
@mthenw

mthenw Jan 25, 2016

Collaborator

Hey, thanks for reporting.

The problem is related to how we load files into zip. https://github.com/apex/apex/blob/master/utils/utils.go#L48. Will try to fix that today.

Collaborator

mthenw commented Jan 25, 2016

Hey, thanks for reporting.

The problem is related to how we load files into zip. https://github.com/apex/apex/blob/master/utils/utils.go#L48. Will try to fix that today.

@tj tj closed this in ffd11b0 Jan 25, 2016

tj added a commit that referenced this issue Jan 25, 2016

Merge pull request #144 from apex/toomanyopen
Fix 'too many open files' error. Fix #143
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment