improve message if curl failed due to permission error #634

Merged
merged 1 commit into from Jan 5, 2017

Projects

None yet

3 participants

@chris-rock
Contributor

This improvements helps users to see if the installation was successful or not.

install.sh
@@ -47,8 +47,13 @@ if [ -z $LATEST ] ; then
echo "Error requesting. Download binary from https://github.com/apex/apex/releases"
exit 1
else
- curl -sL https://github.com/apex/apex/releases/download/$LATEST/apex_$PLATFORM -o $DEST
- chmod +x $DEST
+ echo "Download apex binary from https://github.com/apex/apex/releases/download/$LATEST/apex_$PLATFORM to $DEST"
@tj
tj Jan 5, 2017 Member

Maybe "Downloading" so people don't mistake that as an action they need to take. Otherwise LGTM!

@chris-rock chris-rock improve message if curl failed due to permission error
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
ec21aa8
@chris-rock
Contributor

@tj Good idea. I updated the PR

@mooyoul
mooyoul approved these changes Jan 5, 2017 View changes

I just checked that typo (download -> downloading) was changed. this LGTM :)

@tj tj merged commit e458edf into apex:master Jan 5, 2017
@tj
Member
tj commented Jan 5, 2017

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment