Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `stages` config with higher prededence #314

Closed
tj opened this Issue Sep 8, 2017 · 7 comments

Comments

Projects
None yet
2 participants
@tj
Copy link
Member

tj commented Sep 8, 2017

Basically a mirror of Config, so you can override anything at the stage level. Particularly useful for regions, hooks, and potentially even profile if you'd like a separate account for staging.

@tj tj added this to the 0.4.0 milestone Sep 8, 2017

@kaihendry

This comment has been minimized.

Copy link

kaihendry commented Nov 14, 2017

Oh, I need this since https://static.spuul.com/devops/2017-11-14/up.json doesn't work. 😢

Guess the workaround is to symlink in my up.json, ln -s up.stage.json up.json?

@tj

This comment has been minimized.

Copy link
Member Author

tj commented Nov 15, 2017

Ahh yea I definitely want what you have there to work. In the meantime maybe a --config up.stage.json or similar would be a reasonable option, might be useful for some other cases too

@tj tj removed this from the 0.4.0 milestone Nov 30, 2017

@tj tj added Feature Request and removed Feature Accepted labels Nov 30, 2017

@kaihendry

This comment has been minimized.

Copy link

kaihendry commented Dec 20, 2017

Oh, just realised Error: unknown long flag '--config'. But seriously what you proposed here in #484 (comment) is what I desperately need.

@tj tj added this to the 0.5.0 milestone Dec 20, 2017

@tj

This comment has been minimized.

Copy link
Member Author

tj commented Dec 20, 2017

Sounds good, I'll try and get this in soon, should be pretty straight-forward to implement

@kaihendry

This comment has been minimized.

Copy link

kaihendry commented Jan 8, 2018

Had a breakage and the error was FATA error reading config: open up.json: no such file or directory. Guess up didn't like my symlink!

Yikes, up doesn't support --config yet?! Oh, we are not on 0.5 yet. Sorry.

Btw --env would be in more in line with apex but I guess it might be confused with environment variables.

@tj

This comment has been minimized.

Copy link
Member Author

tj commented Jan 8, 2018

Yeah I'd rather keep it in one file I think, I'll look into the per-stage config today. --config is definitely nice in its simplicity but then you have to maintain two or more when config is basically the same in each, tough call, but having both seems a little wonky.

@tj

This comment has been minimized.

Copy link
Member Author

tj commented Jan 8, 2018

Hmm just realized it doesn't make much sense to swap out profile since up plan / apply do not take a stage, that gets a bit awkward without a cross-account cloudformation setup, I don't want to complicate that too much.

@tj tj closed this in 6c3b87d Jan 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.