Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upgrade --version flag or arg #387

Closed
tj opened this Issue Oct 19, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@tj
Copy link
Member

tj commented Oct 19, 2017

Allowing users to maintain a specific version, this may be useful in the future for breaking changes.

  • test with OSS
  • test with Pro

@tj tj added this to the 0.5.0 milestone Nov 20, 2017

@mitchellhuang

This comment has been minimized.

Copy link

mitchellhuang commented Nov 24, 2017

Yes, I also think this is very important (following from #421). Would also like to add that if you do up upgrade without a ~/.up/config.json set, it will say No updates available, you're good :). It makes sense, because we don't want to upgrade a regular user's binary to a pro binary but the problem is, when doing CI, I would like to have a pre-built image with an up pro binary installed so I don't have to do up upgrade before every up deploy. And I can't build this docker image of all my CI tools and up pro without throwing in a ~/.up/config.json into the image. I'm trying to work around this by running the curl install script with version 0.1.9-pro but it's not working because the binaries for the pro versions are not built on the releases page. Great to see env stuff finally out though and it looks like adding a version flag to up upgrade will fix all of these problems.

Last edit: oh, looks like that guy was having similar troubles as me i should probably read more :-)

@tj

This comment has been minimized.

Copy link
Member Author

tj commented Nov 25, 2017

@huangbong noted! I'll open an issue for making the Pro install more direct. #437

@tj tj closed this in b8e77b6 Jan 5, 2018

@cloudkite

This comment has been minimized.

Copy link

cloudkite commented Jan 5, 2018

@tj nice work! How do we upgrade to specific version of pro? Does it need the pro suffix? ie 0.4.7-pro

@tj

This comment has been minimized.

Copy link
Member Author

tj commented Jan 5, 2018

@cloudkite ah! good question haha, updating the docs for that, but if you're logged in and subscribed it'll always grab Pro, and if the version is incorrect for Pro it'll error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.