Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding NODE_ENV #505

Closed
tj opened this Issue Dec 21, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@tj
Copy link
Member

commented Dec 21, 2017

Right now it's forced to the stage you're deploying to. I think this is best practice personally, as you could treat "staging" as "production", however React and others have rallied around using NODE_ENV=production to strip out development code, so it's pretty much required to allow overriding.

@tj tj added the Refactor label Dec 21, 2017

@yhjor

This comment has been minimized.

Copy link

commented Dec 22, 2017

Agree. Since there is lib like envalid to validate NODE_ENV to whitelist development, test, production, using staging as NODE_ENV will throw error during runtime.

@matsilva

This comment has been minimized.

Copy link

commented Dec 24, 2017

Thanks for this!

@tj tj added this to the 0.5.0 milestone Dec 27, 2017

@tj tj closed this in 13b3b09 Dec 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.