Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to specify the Route53 hosted zone #536

Closed
fahrradflucht opened this Issue Jan 11, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@fahrradflucht
Copy link

fahrradflucht commented Jan 11, 2018

Prerequisites

  • I am running the latest version. (up upgrade)
  • I searched to see if the issue already exists.
  • I inspected the verbose debug output with the -v, --verbose flag.
  • Are you an Up Pro subscriber?

Description

Prior to 3.8 one could use up to create hosted zone / use domains without having the dns of the effective tld plus one mapped to the account. In short prior to 3.8 up supported subdomains as the base domain.

But since ce1ebf5 up always creates a hosted zone for the effective tld plus one. This adds a requirement on DNS that isn't always fulfillable - pointing the base domains DNS to the account.

Steps to Reproduce

With a config like this:

{
	"name": "vwa-osc-scc",
	"lambda": {
		"memory": 256
	},
	"hooks": {
		"build": "",
		"clean": ""
	},
	"stages": {
		"development": {
			"domain": "dev.sub.domain.example.com"
		},
		"production": {
			"domain": "sub.domain.example.com"
		},
		"staging": {
			"domain": "stage.sub.domain.example.com"
		}
	}
}

you would get a hosted zone for example.com. Prior to 3.8 you would have got a hosted zone for domain.example.com.

@tj

This comment has been minimized.

Copy link
Member

tj commented Jan 11, 2018

The old behaviour was more of a bug, at least as a default. Open to having some kind of setting for it, even just "zone": "domain.example.com" alongside the domain maybe

@fahrradflucht

This comment has been minimized.

Copy link
Author

fahrradflucht commented Jan 12, 2018

Yes an option like this would be awesome.

XKCD

@tj tj changed the title No support for subdomain hosted zone creation anymore. Option to specify the Route53 hosted zone Jan 12, 2018

@tj tj added the Feature Request label Jan 12, 2018

@kaihendry

This comment has been minimized.

Copy link

kaihendry commented May 8, 2018

Another vote for this please!
https://s.natalian.org/2018-05-08/subdomains.mp4

Was surprised to see a top level zone created in my dev account 😅

@tj tj referenced this issue May 9, 2018

Closed

DNS zone option #582

@tj tj closed this in 534930d May 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.