Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customization of IAM func role #539

Closed
tj opened this Issue Jan 14, 2018 · 7 comments

Comments

Projects
None yet
3 participants
@tj
Copy link
Member

tj commented Jan 14, 2018

Pretty common to add dynamo/kinesis/s3 access etc, probably time to add this to up.json so people don't have to use the AWS console to manipulate the permissions.

  • add support for defining perms
  • add docs and examples
  • add to json schema

@tj tj added this to the 0.6.0 milestone Jan 14, 2018

@kaihendry

This comment has been minimized.

Copy link

kaihendry commented Jan 15, 2018

Is it acceptable just to add the permissions to the up role in the AWS IAM console, after deploying? It persists IIRC.

@tj

This comment has been minimized.

Copy link
Member Author

tj commented Jan 15, 2018

Yep! That's what I've been doing too

@tj tj removed this from the 0.6.0 milestone Feb 2, 2018

@mgoodings

This comment has been minimized.

Copy link

mgoodings commented Feb 15, 2018

Would save a lot of additional work on our end if we could override the IAM role pragmatically. Currently have to deploy a whole CloudFormation stack to create the role and somehow wire it into Up.

@tj

This comment has been minimized.

Copy link
Member Author

tj commented Feb 15, 2018

I'll prioritize this some more, pretty common to add Dynamo etc and it shouldn't take long to add—I always end up manually tweaking mine in the console but yeah that's not ideal haha.

@tj tj added the Priority label Feb 15, 2018

@mgoodings

This comment has been minimized.

Copy link

mgoodings commented Mar 27, 2018

Any expected ETA on this one? Sorry to pressure.

@tj

This comment has been minimized.

Copy link
Member Author

tj commented Mar 28, 2018

@mgoodings I'm not sure yet how to best handle this since it's not part of the CloudFormation stack, it wouldn't be part of the up stack plan/apply workflow because of that which makes it a little awkward :'(. Might be able to manually add it to plan/apply and "fake it" but that's kind of a gross solution as well.

@tj tj closed this in 9f4faca May 9, 2018

@kaihendry

This comment has been minimized.

Copy link

kaihendry commented May 10, 2018

Just a note that 9f4faca seems to overwrite my edits to the function's inline policy. Didn't expect that. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.