Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logs flushing after "response" log #545

Closed
tj opened this Issue Jan 17, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@tj
Copy link
Member

tj commented Jan 17, 2018

As @kaihendry mentioned in #349. This is due to flushing logs in another goroutine and it's not synchronized.

For example "response" here should be the final log.

  10:54:27am INFO request ip: 127.0.0.1:59004 method: GET path: /json/
  10:54:27am INFO doing some work method: GET route: handleJSON url: /json/
  10:54:27am INFO response duration: 253ms ip: 127.0.0.1:59004 method: GET path: /json/ size: 20 B status: 200
  10:54:27am INFO did some work method: GET route: handleJSON url: /json/

@tj tj added UX Refactor labels Jan 17, 2018

@tj tj added this to the 0.6.0 milestone Jan 17, 2018

@tj tj removed this from the 0.6.0 milestone Feb 2, 2018

@tj tj closed this in ffbcfcf Feb 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.