Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: goroutine leak in lambda report #512

Merged
merged 1 commit into from Dec 25, 2017

Conversation

Projects
None yet
2 participants
@ferhatelmas
Copy link
Contributor

commented Dec 22, 2017

time.Tick leaks its goroutine since it's not manageable. Instead, new ticker is created and deferred to stop as soon as function returns.

@ferhatelmas ferhatelmas force-pushed the ferhatelmas:fix-leak branch from 5b27758 to a85a862 Dec 22, 2017

@tj

This comment has been minimized.

Copy link
Member

commented Dec 22, 2017

not too worried about it in this case since we know everything is short-lived

@ferhatelmas

This comment has been minimized.

Copy link
Contributor Author

commented Dec 22, 2017

Up to you 😄

fix: goroutine leak in lambda report
time.Tick leaks its goroutine since
it's not manageable. Instead, new ticker is
created and deferred to stop as soon as
function returns

@ferhatelmas ferhatelmas force-pushed the ferhatelmas:fix-leak branch from a85a862 to 32a678a Dec 22, 2017

@ferhatelmas

This comment has been minimized.

Copy link
Contributor Author

commented Dec 25, 2017

@tj I wanted to ping if any change in your thinking. I think it's better to keep everything clean and include this change even if it's short-lived. However, if you insist it's not worth of, please close it.

@tj

This comment has been minimized.

Copy link
Member

commented Dec 25, 2017

I'm kind of impartial on that kind of change, but it doesn't hurt!

@tj tj merged commit 15c99d2 into apex:master Dec 25, 2017

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

@ferhatelmas ferhatelmas deleted the ferhatelmas:fix-leak branch Dec 25, 2017

@ferhatelmas

This comment has been minimized.

Copy link
Contributor Author

commented Dec 25, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.