New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow yaxis as an additional prop, so it updates properly #12

Merged
merged 2 commits into from Sep 30, 2018

Conversation

Projects
None yet
2 participants
@passcod
Copy link
Contributor

passcod commented Sep 24, 2018

Fixes #11

I don't think this is or needs to be a breaking change. Previous behaviour of putting yaxis in the options prop will still work, albeit with the same, existing, non-updating behaviour.

@junedchhipa

This comment has been minimized.

Copy link
Contributor

junedchhipa commented Sep 26, 2018

Thanks @passcod I will do a review very soon.
And I agree with your point that it will not be a breaking change as this is just an additional prop user may or may not pass

@junedchhipa junedchhipa merged commit e3b8487 into apexcharts:master Sep 30, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@passcod passcod deleted the passcod:patch-1 branch Sep 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment