Skip to content
This repository was archived by the owner on Dec 25, 2023. It is now read-only.
This repository was archived by the owner on Dec 25, 2023. It is now read-only.

Pre-populate Rename Symbol palette with current value #133

Closed

Description

@alex-ketch

For me, most of the time when renaming a symbol it's to fix a minor typo or adjust the existing name.
The current behaviour is to show placeholder text that can't be selected or edited, requiring the user to type out the full name of the symbol.

Current prompt
Screenshot 2020-11-19 at 11 37 28@2x

I propose populating both the placeholder and value options to make edits easier. This UX would also bring the workflow in line with how VS Code works.

The change would be made at the following place:

{ placeholder: editor.selectedText },

I can make the PR if this change sounds good.

Never mind, the InputPalette API doesn't support the value option, only the InputPanel one does. Will report as a feature request on the Nova dev forum.

EDIT: The feature request forum post can be found here.

Activity

  1. apexskier commented on Nov 22, 2020

    @apexskier
    Owner

    This is definitely what I want to do, but as you've seen it's not supported without moving to the input panel, which I don't like as much. Can you link to the thread in the dev forum when you've posted?

  2. added 3 commits that reference this issue on Apr 22, 2021
    ba22054
    ebd15cc
    aa5a357
  3. added a commit that references this issue on Apr 29, 2021
    cdaab22
  4. github-actions commented on Apr 29, 2021

    @github-actions

    Included in release v2.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestnova-coreSomething is (probably) Nova's fault

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions