Skip to content
This repository has been archived by the owner on Dec 25, 2023. It is now read-only.

Pre-populate Rename Symbol palette with current value #133

Closed
alex-ketch opened this issue Nov 19, 2020 · 2 comments · Fixed by #237
Closed

Pre-populate Rename Symbol palette with current value #133

alex-ketch opened this issue Nov 19, 2020 · 2 comments · Fixed by #237
Labels
enhancement New feature or request nova-core Something is (probably) Nova's fault

Comments

@alex-ketch
Copy link
Contributor

alex-ketch commented Nov 19, 2020

For me, most of the time when renaming a symbol it's to fix a minor typo or adjust the existing name.
The current behaviour is to show placeholder text that can't be selected or edited, requiring the user to type out the full name of the symbol.

Current prompt
Screenshot 2020-11-19 at 11 37 28@2x

I propose populating both the placeholder and value options to make edits easier. This UX would also bring the workflow in line with how VS Code works.

The change would be made at the following place:

{ placeholder: editor.selectedText },

I can make the PR if this change sounds good.

Never mind, the InputPalette API doesn't support the value option, only the InputPanel one does. Will report as a feature request on the Nova dev forum.

EDIT: The feature request forum post can be found here.

@apexskier apexskier added enhancement New feature or request nova-core Something is (probably) Nova's fault labels Nov 22, 2020
@apexskier
Copy link
Owner

This is definitely what I want to do, but as you've seen it's not supported without moving to the input panel, which I don't like as much. Can you link to the thread in the dev forum when you've posted?

alex-ketch added a commit to alex-ketch/nova-typescript that referenced this issue Apr 22, 2021
alex-ketch added a commit to alex-ketch/nova-typescript that referenced this issue Apr 28, 2021
alex-ketch added a commit to alex-ketch/nova-typescript that referenced this issue Apr 28, 2021
@github-actions
Copy link

Included in release v2.3.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request nova-core Something is (probably) Nova's fault
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants