Skip to content
Commits on May 7, 2013
  1. @AnhNhan
Commits on Apr 25, 2013
  1. @AnhNhan
Commits on Apr 18, 2013
  1. @AnhNhan @epriestley

    Making DifferentialListController more mobile-friendly

    Summary:
    We now have the app menu top-right, so we don't need the side navbar anymore
    
    Refs T2014
    
    Test Plan: Visited list view in narrow / wide browser. Could access everything either directly (tables :P) or the top right menus
    
    Reviewers: epriestley, chad
    
    Reviewed By: epriestley
    
    CC: aran, Korvin
    
    Maniphest Tasks: T2014
    
    Differential Revision: https://secure.phabricator.com/D5728
    AnhNhan committed with epriestley Apr 18, 2013
  2. @AnhNhan @epriestley

    Applying (user )?monospace font to remarkup code blocks

    Summary:
    I feel that remarkup code blocks are still kind of small. This should help with my reading problems. Hesitating to add `.PhabricatorMonospaced` to the remarkup rule, since it's pretty specific to Phabricator.
    
    Pasting in the diff btw, since my `arc`'s going crazy (doubt that's `arc.exe`, since it's not landed yet).
    
    Test Plan:
    Set font to something large. viewed code block. Was not large.
    
    Applied change. Viewed code block again. It was //**HUGE**//!
    
    Also verified that the `init.js` was still there. I think that's the one being inserted `$5`.
    
    Reviewers: epriestley, chad
    
    Reviewed By: epriestley
    
    CC: aran, Korvin
    
    Differential Revision: https://secure.phabricator.com/D5727
    AnhNhan committed with epriestley Apr 18, 2013
  3. @AnhNhan
Commits on Apr 15, 2013
  1. @AnhNhan @epriestley

    Probably added app menu for mobile

    Summary:
    Messy POC. I hope I did this one right :P
    
    Refs T2014
    
    Test Plan: Switched browser forcefully into `device-phone`, saw filters in the menu top right. Browsed around Differential in desktop mode, nothing was broken, I think.
    
    Reviewers: epriestley, chad, btrahan
    
    CC: aran, Korvin
    
    Maniphest Tasks: T2014
    
    Differential Revision: https://secure.phabricator.com/D5693
    AnhNhan committed with epriestley Apr 15, 2013
  2. @AnhNhan @epriestley

    Adding an own application for search

    Summary:
    Refs T2989
    
    Renamed file
    
    Libery
    
    Test Plan: Nothing broken, that's always a good sign.
    
    Reviewers: epriestley
    
    Reviewed By: epriestley
    
    CC: aran, Korvin
    
    Maniphest Tasks: T2989
    
    Differential Revision: https://secure.phabricator.com/D5697
    
    Conflicts:
    
    	src/__phutil_library_map__.php
    AnhNhan committed with epriestley Apr 15, 2013
  3. @AnhNhan @epriestley

    Greyed out some icons, removed colors from Phriction updates

    Summary:
    @chad The colors were indeed terrible. Why didn't you tell me
    
    Also greyed out diff icons when no diff available. Makes it more clear that you can't click it on mobile.
    
    Test Plan: Saw it on mobile and desktop.
    
    Reviewers: epriestley, chad
    
    Reviewed By: epriestley
    
    CC: aran, Korvin
    
    Differential Revision: https://secure.phabricator.com/D5694
    AnhNhan committed with epriestley Apr 15, 2013
Commits on Apr 11, 2013
  1. @AnhNhan @epriestley

    Restored title for object handles

    Summary: I shouldn't delete code because it has no call-sites :P
    
    Test Plan: Set my status to away, verified I got a hover title (no card).
    
    Reviewers: vrana, epriestley
    
    Reviewed By: epriestley
    
    CC: aran, Korvin
    
    Differential Revision: https://secure.phabricator.com/D5662
    AnhNhan committed with epriestley Apr 11, 2013
Commits on Apr 10, 2013
  1. @AnhNhan
Commits on Apr 9, 2013
  1. @AnhNhan
  2. @AnhNhan
  3. @AnhNhan
Commits on Apr 8, 2013
  1. @AnhNhan @epriestley

    Displaying links instead of dumping raw remarkup in Phriction mails

    Summary:
    Fixes T2900 - Display link to document version and diff for edited Phriction Documents.
    
    Also display the target document for moved pages.
    
    Test Plan: Edited/Moved some pages, verified that the links are linking to the correct versions.
    
    Reviewers: epriestley
    
    Reviewed By: epriestley
    
    CC: adityar7, aran, Korvin
    
    Maniphest Tasks: T2900
    
    Differential Revision: https://secure.phabricator.com/D5615
    AnhNhan committed with epriestley Apr 8, 2013
  2. @AnhNhan @epriestley

    Fix the attempt of graceful alignment for Hovercards

    Summary:
    Refs T1048; Fixes T2902 - (Probably) fixes @vrana's issue. I managed
    to repro it on Ubuntu FF (though on Windows with 1.0GHz/512MB it's
    really worse...).
    
    This revises the approach to the graceful degradation for
    `too-far-to-the-screen-edge-edge-case`.
    
    I noticed that `x` could become very negative, up to about ~`-170px`.
    This is due to the //"already-on-the-left-side"// nature of object tags.
    `50 - 200 - 20` = `negative`. Adding `100px` (node.dimension.x / 4) to
    that won't really help, as the hovercard would still be offscreen.
    
    Instead, display them left-aligned with the object tags on the left edge
    per default, and offer centerization in center cases. This is also better
    for Pholio, Phriction, which have a way lower min-x than Maniphest,
    Differential.
    
    I also disabled placing the hovercard below the tag in case there's not
    enough space on the north side. The hovercard would not display 99.99% of
    the times after being hidden (and it retains the flickering behaviour).
    Another reason is also our current hide-behaviour, which only assumes
    north-side alignment. Adding south-side didn't really work (I'm bad with
    JS), so I didn't bother with it. Disabling this is //acceptable//, since
    it only really affects Pholio, Phriction. And nobody places object tags
    in the first line, anyway. Except for my test pages, of course :/
    
    Btw, this also removes the weird jaggy horizontal shifts for object of
    various lengths (e.g. `{D4356}`, `{rP32ofhw0842obw}` etc.). I think
    that's only good.
    
    Test Plan:
    Hovered in Pholio, Phriction in Chrome, FF. Did not touch
    left screen border.
    
    Hovered in Maniphest, Differential. Tags farther to the left were
    aligned left, tags more in the center were pretty centered.
    
    Reviewers: epriestley, vrana
    
    Reviewed By: epriestley
    
    CC: aran, Korvin
    
    Maniphest Tasks: T1048, T2902
    
    Differential Revision: https://secure.phabricator.com/D5612
    AnhNhan committed with epriestley Apr 7, 2013
Commits on Apr 6, 2013
  1. @AnhNhan @epriestley

    Fix flickering hovercards

    Summary:
    Refs T1048, T2902 - This //should// fix flickering hovercards. Probably does not fix displaced hovercards, though could (because of the flickering doing something bad to rendering).
    
    I'm bad with JS D:
    
    Test Plan: Tried out plenty of reload & hover combos. No flickering anymore. Never again.
    
    Reviewers: epriestley, vrana
    
    Reviewed By: epriestley
    
    CC: aran, Korvin
    
    Maniphest Tasks: T1048
    
    Differential Revision: https://secure.phabricator.com/D5607
    AnhNhan committed with epriestley Apr 6, 2013
  2. @AnhNhan @epriestley

    Fixing non-square profile images for hovercards

    Summary: Refs T1048 - disables bg repeat, centers profile image
    
    Test Plan: looked at my own hovercard in my local install, which has a non-square prof pic
    
    Reviewers: epriestley, chad
    
    Reviewed By: epriestley
    
    CC: aran, Korvin
    
    Maniphest Tasks: T1048
    
    Differential Revision: https://secure.phabricator.com/D5604
    AnhNhan committed with epriestley Apr 6, 2013
  3. @AnhNhan
  4. @AnhNhan @epriestley

    Adding hovercard event listeners for Users, Revisions, Conpherence an…

    …d Commits
    
    Summary:
    Refs T1048
    
    Adding Differential Hovercard EventListener
    
    Adding People Hovercard EventListener
    
    Adding basic Diffusion hovercard
    
    Adding Conpherence Hovercard EventListener
    
    Test Plan:
    Used in a combo with working hovercards. So beautiful.
    
    Also visited test page. Works alright.
    
    awesometown
    
    Reviewers: epriestley, chad, btrahan
    
    Reviewed By: epriestley
    
    CC: aran, Korvin
    
    Maniphest Tasks: T1048
    
    Differential Revision: https://secure.phabricator.com/D5576
    AnhNhan committed with epriestley Apr 5, 2013
  5. @AnhNhan @epriestley

    Introduce some convenience methods for handle rendering

    Summary:
    So I don't have to copy/paste everything again.
    
    Used them at places I could find with my limited `grep` skills.
    
    Test Plan: Visited hovercards, revision and tasks. No crashes.
    
    Reviewers: epriestley, btrahan, chad
    
    Reviewed By: epriestley
    
    CC: aran, Korvin
    
    Differential Revision: https://secure.phabricator.com/D5592
    AnhNhan committed with epriestley Apr 5, 2013
Commits on Apr 5, 2013
  1. @AnhNhan @epriestley

    Fixing a race condition for hovercards

    Summary:
    Refs T1048 - Take this setup:
    
    D123 D321
    
    Hover with the mouse over one object, and move to another one before it got loaded. You'll have two hovercards. Of these you can't get rid of one anymore. Not through resizing, not through showing another hovercard. (You may have to try a few times). I think it only happens when #2 loads faster than #1. #2 is displayed, then #1 gets loaded and draws.
    
    Or something like that. You could have a race condition where one draws after another and overwrites the current node/anchor, without hiding it. This renders the previous card unhideable, even on resize / mouse far away.
    
    Test Plan:
    Did a repro by hovering a lot.
    
    Applied this change. Could not repro anymore.
    
    Reviewers: epriestley
    
    Reviewed By: epriestley
    
    CC: aran, Korvin
    
    Maniphest Tasks: T1048
    
    Differential Revision: https://secure.phabricator.com/D5594
    AnhNhan committed with epriestley Apr 5, 2013
  2. @AnhNhan @epriestley

    Use PhabricatorTagView in user mentions

    Summary:
    Refs T1048 - Use `PhabricatorTagView` in user mention remarkup rules. Emits hovercards now :D
    
    Also introduces `PhabricatorTagView::COLOR_INEXISTENT`
    
    Test Plan: Inspected HTML to find sigil & meta ref. Hovered above them (with hovercard patch, sold separately). Hovercard appeared.
    
    Reviewers: epriestley, chad, btrahan
    
    Reviewed By: epriestley
    
    CC: aran, Korvin
    
    Maniphest Tasks: T1048
    
    Differential Revision: https://secure.phabricator.com/D5573
    AnhNhan committed with epriestley Apr 5, 2013
  3. @AnhNhan @epriestley

    Hovercard front-end code & stuff

    Summary:
    Refs T1048; Depends on D5557, D5558
    
    They hover right above your eyes. Try it out at home :D (in that case, don't forget to checkout D5557 and D5558)
    
    Worth a lot of improvement. But it's great for now after a little bit of styling.
    
    Scrape load (search current document for all hovercards and pre-load them) and lazy load (e.g. previewing comments which is not covered by scrape load) implemented.
    
    Added some seemingly useful graceful situations. Too much to the left, too much to the top.
    
    Test Plan:
    Tested on Ubuntu, Chrome and FF. No Windows yet, since I have it live at no place. Works pretty fine, at least it will appear.
    
    Could test left graceful fallback. Don't know what happens if you place it too far to the top. I expect either good results or placement about the center of the screen in case of glitches.
    
    For now, they'll disappear right away once the mouse leaves the object tag. Intended is when leaving both tag and hovercard.
    
    Reviewers: epriestley, chad, btrahan
    
    CC: aran, Korvin
    
    Maniphest Tasks: T1048
    
    Differential Revision: https://secure.phabricator.com/D5563
    
    Conflicts:
    
    	src/__celerity_resource_map__.php
    AnhNhan committed with epriestley Apr 5, 2013
  4. @AnhNhan
  5. @AnhNhan @epriestley

    Based hovercards on ActionHeader

    Summary: Refs T1048 - Makes it look //way// better
    
    Test Plan: {F39347}
    
    Reviewers: chad, epriestley, btrahan
    
    Reviewed By: epriestley
    
    CC: aran, Korvin
    
    Maniphest Tasks: T1048
    
    Differential Revision: https://secure.phabricator.com/D5587
    AnhNhan committed with epriestley Apr 5, 2013
  6. @AnhNhan @epriestley

    Changing default fallback behaviour of hovercard view

    Summary:
    Refs T1048; Depends on D5571 - Use names instead of `substr($handle->getType(), 0, 1).$handle->getAlternateID()`, which did not work for 70% of the handles
    
    This, of course, breaks UI Examples, which was pretty off before anyway.
    
    Unbreak UIExamples.
    
    Test Plan: UIExamples, Hovercard Controller in human test mode
    
    Reviewers: epriestley, btrahan
    
    Reviewed By: epriestley
    
    CC: aran, Korvin
    
    Maniphest Tasks: T1048
    
    Differential Revision: https://secure.phabricator.com/D5572
    AnhNhan committed with epriestley Apr 5, 2013
  7. @AnhNhan

    Merge branch 'master' of github.com:facebook/phabricator

    Conflicts:
    	.gitignore
    AnhNhan committed Apr 5, 2013
Commits on Apr 4, 2013
  1. @AnhNhan @epriestley

    Uniformized handle data

    Summary:
    This sets more reasonable values for the object handle fields imo. It's not like I ever want to find out what letter to use and then do `substr($handle->getType(), 0, 1).$handle->getID()` to get `D1` each time I use handles.
    
    Name:
    
    - D1
    - T1
    - M1
    - P1
    - etc.
    
    Fullname:
    
    - D1: Something
    - T1: Something
    - etc.
    
    In addition, this helps me to reasonable prefill Hovercards in case there is no application-specific event listener.
    
    Also deletes `title` and `alternateID` completely. They deserved that.
    
    Test Plan:
    Visited places, nothing broke (We only ever used `$handle->getName()` for users and commits).
    
    Tested mail reply handler. Did not test the other way around, but should be fine.
    
    Hovercards broken until D5572 (would love to induce a cyclic dependency)
    
    Reviewers: epriestley, chad, btrahan
    
    Reviewed By: epriestley
    
    CC: aran, Korvin
    
    Differential Revision: https://secure.phabricator.com/D5571
    AnhNhan committed with epriestley Apr 4, 2013
  2. @AnhNhan

    Merge branch 'master' of github.com:facebook/phabricator

    Conflicts:
    	.gitignore
    AnhNhan committed Apr 4, 2013
Commits on Apr 3, 2013
  1. @AnhNhan @epriestley

    Added separation of flags according to ordering

    Summary:
    Refs T2841 - Exactly what it says on the tin
    
    Turned some ordering around.
    
     - Color is `ASC` to be in line with the flag dialog
     - Object type is `DESC`, since `TASK` and `DREV` are sure more of
       interest than `CMIT`
    
    NOTE: May not work properly without D5514, since only a few
    object handle types implement `getTypeName()` properly. The fallback
    return value is `null`, after which we group when sorting per object
    type. Dis gun b gud!
    
    .
    
    NOTE: Technically does not de-pend on D5517, though you may get a merge conflict. Prefer this one if you for some reason happen to push this one before D5517
    
    Test Plan:
    {F38202}
    {F38203}
    {F38204}
    
    Reviewers: epriestley, btrahan
    
    CC: aran, Korvin
    
    Maniphest Tasks: T2841
    
    Differential Revision: https://secure.phabricator.com/D5518
    
    Conflicts:
    
    	src/applications/flag/controller/PhabricatorFlagListController.php
    AnhNhan committed with epriestley Apr 3, 2013
  2. @AnhNhan @epriestley

    Add Maniphest Hovercard event listener

    Summary:
    Refs T1048
    badassery
    
    Test Plan: Used in a future diff. Verified correct appearance of hovercard
    
    Reviewers: epriestley
    
    Reviewed By: epriestley
    
    CC: aran, Korvin
    
    Maniphest Tasks: T1048
    
    Differential Revision: https://secure.phabricator.com/D5544
    AnhNhan committed with epriestley Apr 3, 2013
  3. @AnhNhan @epriestley

    Added basic hovercard controller

    Summary:
    Refs T1048; Depends on D5542, D5543, D5544 - It currently just renders multiple hovercards nicely for test purposes. More is on the way.
    
    Mode `test`: Human test chamber.
    Mode `retrieve`: For JS. Added so it would not clash with search key routing.
    
    badassery
    
    Test Plan:
    `/search/hovercard/test/?phids[hover-T4]=PHID-TASK-g5pduvwrrwvkq5gkx736&phids[hover-T2]=PHID-TASK-gta6lzaaagziavkktima`
    
    Verified the appearance of two tasks with correct rendering and correct ids
    
    Reviewers: epriestley
    
    Reviewed By: epriestley
    
    CC: aran, Korvin
    
    Maniphest Tasks: T1048
    
    Differential Revision: https://secure.phabricator.com/D5545
    AnhNhan committed with epriestley Apr 3, 2013
  4. @AnhNhan @epriestley

    Streamline tag rendering for Differential and Maniphest

    Summary:
    Well, I'm just putting it into the DAO classes, or am I doing something wrong?
    
    Will be used by future event listeners
    
    Test Plan: Visited some tasks and revisions. Look fine.
    
    Reviewers: epriestley
    
    Reviewed By: epriestley
    
    CC: aran, Korvin
    
    Differential Revision: https://secure.phabricator.com/D5542
    AnhNhan committed with epriestley Apr 3, 2013
Commits on Apr 2, 2013
  1. @AnhNhan @epriestley

    First pass at hovercard design

    Summary:
    Refs T1048 - I'm pretty happy and happy to tell you
    
    Savepoint CR
    
    Everything's dummy right now. If you are testing locally, don't forget to edit the PHIDs. Or populate your own handles. Doesn't really matter.
    
    I'm mainly sending it in for the CSS, not the messy PHP code. Ignore the `margin: auto`, that's just for looking nice.
    
    Test Plan: UI Example » Hovercard
    
    Reviewers: epriestley, chad
    
    CC: aran, Korvin
    
    Maniphest Tasks: T1048
    
    Differential Revision: https://secure.phabricator.com/D5519
    AnhNhan committed with epriestley Apr 2, 2013
  2. @AnhNhan @epriestley

    Fix failing unit test `testParentEdgeCases` under Windows

    Summary: Noticed that this one was failing under Windows for the test cases where the root path (`/`) was supposed to be returned. Was returned Windows-style, made it return UNIX-style. All others work fine (return slashes as-is).
    
    Test Plan:
    `arc unit --everything` before and after this patch on Windows.
    
    Will try out Ubuntu in near future.
    
    Reviewers: epriestley, vrana
    
    Reviewed By: vrana
    
    CC: aran, Korvin, vrana
    
    Differential Revision: https://secure.phabricator.com/D5497
    AnhNhan committed with epriestley Apr 2, 2013
Something went wrong with that request. Please try again.