Small code tweaks #2046
Merged
Small code tweaks #2046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
teohhanhui
reviewed
Jun 26, 2018
| @@ -22,7 +22,7 @@ | |||
| * @author Kévin Dunglas <dunglas@gmail.com> | |||
| * @author Baptiste Meyer <baptiste.meyer@gmail.com> | |||
| */ | |||
| class WriteListener | |||
| final class WriteListener | |||
There was a problem hiding this comment.
Can we really do this? It's a BC break, no?
There was a problem hiding this comment.
Yes! I think we did it in another file recently and we accepted it anyway.
There was a problem hiding this comment.
We considered it as a bug fix... Because our policy is to make all classes final by default. But it's border line I agree.
What I suggest: make it final, if someone complain switch to @final. It's a brand new class, the chances somebody actually extended it are low.
teohhanhui
approved these changes
Jun 26, 2018
Simperfit
approved these changes
Jun 27, 2018
|
Thanks @soyuka |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add final to the WriteListener
Don't call getResponse in the cache, use the variable instead