[WIP] Phpcr support #2162
[WIP] Phpcr support #2162
Conversation
…actory' not found
Remove idea
- add symfony mongo test - add mongo on travis & appveyor
- add symfony mongo test - add mongo on travis & appveyor
into samvdb-odm-support # Conflicts: # appveyor.yml # composer.json # src/Bridge/Doctrine/Filter/AbstractFilter.php # src/Bridge/Symfony/Bundle/DependencyInjection/Compiler/DoctrineQueryExtensionPass.php # src/Bridge/Symfony/Bundle/DependencyInjection/Configuration.php # tests/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtensionTest.php # tests/Bridge/Symfony/Bundle/DependencyInjection/Compiler/DoctrineQueryExtensionPassTest.php # tests/Bridge/Symfony/Bundle/DependencyInjection/ConfigurationTest.php
Samvdb odm support
into samvdb-odm-support # Conflicts: # appveyor.yml # composer.json # src/Bridge/Doctrine/Filter/AbstractFilter.php # src/Bridge/Symfony/Bundle/DependencyInjection/Compiler/DoctrineQueryExtensionPass.php # src/Bridge/Symfony/Bundle/DependencyInjection/Configuration.php # tests/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtensionTest.php # tests/Bridge/Symfony/Bundle/DependencyInjection/Compiler/DoctrineQueryExtensionPassTest.php # tests/Bridge/Symfony/Bundle/DependencyInjection/ConfigurationTest.php
| @@ -16,6 +16,7 @@ | |||
| "php": ">=7.1", | |||
|
|
|||
| "doctrine/inflector": "^1.0", | |||
| "jackalope/jackalope-doctrine-dbal": "^1.3", | |||
There was a problem hiding this comment.
does api platform not work without phpcr? i fear that this is an "optional dependency". would it be possible to do a api-platform/phpcr integration package instead?
There was a problem hiding this comment.
mh maybe at the end. but i do not know if we want to move this bundle in the same virtual packagage situation, we are, shall we?
| @@ -28,6 +29,7 @@ | |||
| "require-dev": { | |||
| "symfony/http-foundation": "^3.1@dev || ^4.0@dev", | |||
|
|
|||
| "alcaeus/mongo-php-adapter": "^1.1", | |||
There was a problem hiding this comment.
i would recommend to not mix mongodb and phpcr support into one pull request. it will be easier to review if its first one and then the other once that goes through.
| @@ -113,9 +122,10 @@ public function removeAcceptHeaderBeforeScenario() | |||
| */ | |||
| public function createDatabase() | |||
| { | |||
| $this->schemaTool->dropSchema($this->classes); | |||
| $this->isOrm() && $this->schemaTool->dropSchema($this->classes); | |||
| $this->isOdm() && $this->schemaManager->dropDatabases(); | |||
There was a problem hiding this comment.
could it make sense to split the context into two subclasses instead?
There was a problem hiding this comment.
There is a lot to separate at the end. I think we should move the complete extension stuff into separate classes as we did it in our sonata-admin-integration-bundle when the branches a really separated, we should see what each implementation is needing.
|
@dbu is tried to do it on top of the other branch, but selected the wrong one. Now i can not change it anymore. |
|
will move that one to the right branch. |
This one is really hot-WIP. At the end i wanna get PHPCR support at the API together with mongoDB. That is the reason why i depend on @alanpoulain's branch. We also have to be carefull to devide common stuff and implementation stuff.
Issues i faced and goanna face:
@dbu please feel the ping to be informed, no hurry to invest time,but be informed :-)