New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GraphQL] Check item resource class in mutation #2441
Conversation
|
Fixed php-cs failure |
|
Nice! Could you add tests? |
|
I added a Behat test but can't get it to succeed. I think it's something to do with the escaped quotes in the error message, any ideas? |
|
Could you try to remove the escaping of the double quotes (or maybe to escape the non escaped ones)? |
|
I tried almost every combination I could think of (single quotes, double quotes, double-escape, no escape). I'll have another look, but from the output of Behat it should match, shouldn't it? Edit: json_decode on the string worked |
This prevents passing IRIs belonging to different resource classes
|
@alanpoulain Fixed the test. Is there anything else needed? |
|
LGTM |
|
Thank you @lukasluecke |
This prevents passing IRIs belonging to different resource classes
This prevents passing IRIs belonging to different resource classes, which would bypass access control in some instances (see #2364).