Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (cache): prevent avoidable purge #2697

Merged
merged 2 commits into from Apr 6, 2019

Conversation

Projects
None yet
2 participants
@GregoireHebert
Copy link
Contributor

commented Apr 6, 2019

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets ~
License MIT
Doc PR ~

#EUFOSSA

Since we can get rid of get operations, we should not trigger the cache for these.
Moreover we should not call purge method if there is nothing to purge.

GregoireHebert added some commits Apr 6, 2019

@GregoireHebert GregoireHebert force-pushed the GregoireHebert:fix-cache-purge branch from cdb51f7 to a228079 Apr 6, 2019

@GregoireHebert GregoireHebert changed the title [WIP] fix (cache): prevent avoidable purge fix (cache): prevent avoidable purge Apr 6, 2019

@soyuka soyuka merged commit 0569e10 into api-platform:2.4 Apr 6, 2019

11 checks passed

Scrutinizer Analysis: No new issues – Tests: passed
Details
SymfonyInsight: dunglas / API Platform Core Code quality OK.
Details
ci/circleci: behat-coverage Your tests passed on CircleCI!
Details
ci/circleci: merge-and-upload-coverage Your tests passed on CircleCI!
Details
ci/circleci: php-cs-fixer Your tests passed on CircleCI!
Details
ci/circleci: phpstan Your tests passed on CircleCI!
Details
ci/circleci: phpunit-coverage Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 95.8%)
Details
codecov/project 95.82% (+0.02%) compared to 9eafd71
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@soyuka

This comment has been minimized.

Copy link
Member

commented Apr 6, 2019

@GregoireHebert GregoireHebert deleted the GregoireHebert:fix-cache-purge branch Apr 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.