Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test input messenger with MongoDB #2705

Merged

Conversation

Projects
None yet
3 participants
@alanpoulain
Copy link
Member

alanpoulain commented Apr 7, 2019

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

Input messenger was not tested with MongoDB.

@alanpoulain alanpoulain added the MongoDB label Apr 7, 2019

@alanpoulain alanpoulain force-pushed the alanpoulain:mongodb-test-messenger-input branch from f08382a to 481da7c Apr 7, 2019

@soyuka

This comment has been minimized.

Copy link
Member

soyuka commented Apr 7, 2019

Maybe we could update CONTRIBUTING.md with instructions about adding tests (duplicate entities) on mongodb and how to run them APP_ENV=mongodb.

Also, as ODM annotations aren't the same as ORM ones, maybe we could add matches between the two?

@alanpoulain alanpoulain merged commit 3206429 into api-platform:2.4 Apr 7, 2019

11 checks passed

Scrutinizer Analysis: No new issues – Tests: passed
Details
SymfonyInsight: dunglas / API Platform Core Code quality OK.
Details
ci/circleci: behat-coverage Your tests passed on CircleCI!
Details
ci/circleci: merge-and-upload-coverage Your tests passed on CircleCI!
Details
ci/circleci: php-cs-fixer Your tests passed on CircleCI!
Details
ci/circleci: phpstan Your tests passed on CircleCI!
Details
ci/circleci: phpunit-coverage Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 6826437...481da7c
Details
codecov/project 95.82% remains the same compared to 6826437
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.