Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatiblity with Symfony 4.3 #2784

Merged
merged 13 commits into from Jun 16, 2019
Merged

Compatiblity with Symfony 4.3 #2784

merged 13 commits into from Jun 16, 2019

Conversation

@dunglas
Copy link
Member

dunglas commented May 10, 2019

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a
@dunglas dunglas changed the base branch from master to 2.4 May 10, 2019
@dunglas dunglas changed the base branch from 2.4 to master May 10, 2019
@dunglas dunglas force-pushed the dunglas:sf4.3-compat branch from b3ee949 to 6127157 May 15, 2019
@alanpoulain alanpoulain force-pushed the dunglas:sf4.3-compat branch 4 times, most recently from 1aa8822 to 58ace00 May 31, 2019
@alanpoulain alanpoulain marked this pull request as ready for review May 31, 2019
@alanpoulain alanpoulain force-pushed the dunglas:sf4.3-compat branch 10 times, most recently from 4b2af33 to 5f58782 May 31, 2019
@soyuka soyuka force-pushed the dunglas:sf4.3-compat branch 2 times, most recently from f140dac to 04d6f0b Jun 4, 2019
@soyuka soyuka force-pushed the dunglas:sf4.3-compat branch 2 times, most recently from 315509b to ccfafca Jun 14, 2019
@dunglas dunglas force-pushed the dunglas:sf4.3-compat branch from 3440da5 to 6d16731 Jun 15, 2019
dunglas added 2 commits May 10, 2019
dunglas and others added 9 commits May 16, 2019
@dunglas dunglas force-pushed the dunglas:sf4.3-compat branch from 6d16731 to 22e953c Jun 15, 2019
@dunglas dunglas merged commit 6e2c268 into api-platform:master Jun 16, 2019
10 of 12 checks passed
10 of 12 checks passed
codecov/patch 88% of diff hit (target 94.12%)
Details
codecov/project 93.74% (-0.38%) compared to e18bffb
Details
Scrutinizer Analysis: 2 new issues, 4 updated code elements – Tests: passed
Details
ci/circleci: behat-coverage Your tests passed on CircleCI!
Details
ci/circleci: behat-elasticsearch-coverage Your tests passed on CircleCI!
Details
ci/circleci: behat-mongodb-coverage Your tests passed on CircleCI!
Details
ci/circleci: php-cs-fixer Your tests passed on CircleCI!
Details
ci/circleci: phpstan Your tests passed on CircleCI!
Details
ci/circleci: phpunit-coverage Your tests passed on CircleCI!
Details
ci/circleci: phpunit-mongodb-coverage Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dunglas dunglas deleted the dunglas:sf4.3-compat branch Jun 16, 2019
@dunglas

This comment has been minimized.

Copy link
Member Author

dunglas commented Jun 16, 2019

Thank you very much @soyuka and @alanpoulain for the help!

composer.json Show resolved Hide resolved
@@ -30,8 +30,6 @@
/**
* Generic item normalizer.
*
* @final

This comment has been minimized.

Copy link
@teohhanhui

teohhanhui Jun 18, 2019

Member

I don't think this is right. The GraphQL ItemNormalizer should stop extending this class instead, but instead extend AbstractItemNormalizer.

@@ -96,10 +97,11 @@ protected function configureContainer(ContainerBuilder $c, LoaderInterface $load

$loader->load(__DIR__."/config/config_{$this->getEnvironment()}.yml");

$alg = class_exists(SodiumPasswordEncoder::class) && SodiumPasswordEncoder::isSupported() ? 'auto' : 'bcrypt';

This comment has been minimized.

Copy link
@teohhanhui

teohhanhui Jun 18, 2019

Member

Uhh... Symfony really screwed this one up. :x

This comment has been minimized.

Copy link
@maxhelias

maxhelias Jun 18, 2019

Contributor

It's not bcrypt if sodium isn't supported but the native encoder. I do not know if it's important here.
The bcrypt encoder is now deprecated

This comment has been minimized.

Copy link
@dunglas

dunglas Jun 18, 2019

Author Member

It's only for old versions so I think we don't care (this code will go be thrown away at some point).

@teohhanhui

This comment has been minimized.

Copy link
Member

teohhanhui commented Jun 18, 2019

It seems like this is not addressed? #2856

@soyuka

This comment has been minimized.

Copy link
Member

soyuka commented Jun 18, 2019

I'm not sure to understand how #2856 is an issue here...

@teohhanhui

This comment has been minimized.

Copy link
Member

teohhanhui commented Jun 18, 2019

@soyuka No, it's not an issue here. Just that I'd consider #2856 essential for Symfony 4.3 compatibility. Because it's not doing the right thing now.

@soyuka

This comment has been minimized.

Copy link
Member

soyuka commented Jun 21, 2019

True although I'm not sure to get what we need to do on our side.

@bastnic

This comment has been minimized.

Copy link
Contributor

bastnic commented Jun 26, 2019

Why only master and not 2.4 branch ? My tests are full of 59403x: Method "ApiPlatform\Core\Serializer\ItemNormalizer::createChildContext()" will have a third "?string $format" argument in version 5.0; not defining it is deprecated since Symfony 4.3.

@dunglas

This comment has been minimized.

Copy link
Member Author

dunglas commented Jun 26, 2019

Because Messenger. Messenger 4.3 introduces some BC breaks, that in cascade force us to add some BC breaks too. Also, to use Messenger 4.3 we had to bump the version of several other Symfony components. We then decided that it wasn't a good idea to introduce such changes in a patch release.
Anyway, we're working hard on finishing 2.5, a beta should be available soon.

@teohhanhui

This comment has been minimized.

Copy link
Member

teohhanhui commented Jun 26, 2019

We could certainly backport the other changes that are not related to Symfony Messenger.

@dunglas

This comment has been minimized.

Copy link
Member Author

dunglas commented Jun 26, 2019

Maybe some of them yes! Feel free to open a PR!

betd-sthibault added a commit to betd-sthibault/core that referenced this pull request Aug 7, 2019
* Compatiblity with Symfony 4.3

* Fix all broken unit tests

* Fix some deprecations

* Remove @Final from ItemNormalizer

* Fix Behat tests

* Use composition for the Exception Listener

* Fix default firewall logout_on_user_change deprecation

* Make sure that sodium is supported

* Fix composer and tests

* Fix PHPStan config and CS

* Remove deprecated option

* Fix MongoDB

* Fix rebase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.