Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compat with Symfony 5 #3242

Merged
merged 2 commits into from Nov 11, 2019

Conversation

@nicolas-grekas
Copy link
Contributor

nicolas-grekas commented Nov 8, 2019

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tickets -
License MIT
Doc PR -
@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:sf5 branch from e9fa8ab to bc3ba01 Nov 8, 2019
composer.json Outdated Show resolved Hide resolved
@fabpot

This comment has been minimized.

Copy link

fabpot commented Nov 11, 2019

4.3.7 has been released now :)

@dunglas dunglas force-pushed the nicolas-grekas:sf5 branch 2 times, most recently from d9663b4 to 03ff275 Nov 11, 2019
@dunglas dunglas force-pushed the nicolas-grekas:sf5 branch from 03ff275 to 2e22ff6 Nov 11, 2019
@teohhanhui

This comment has been minimized.

Copy link
Member

teohhanhui commented Nov 11, 2019

CI failure is I/O error: https://github.com/api-platform/core/pull/3242/checks?check_run_id=298039241

Looks like it just needs another force push, since GitHub Actions doesn't support re-runs yet.

@dunglas dunglas merged commit a2dbb3c into api-platform:2.5 Nov 11, 2019
28 of 30 checks passed
28 of 30 checks passed
PHPUnit (PHP 7.1)
Details
PHPUnit (PHP 7.2)
Details
PHPUnit (PHP 7.3)
Details
PHPUnit (PHP 7.4-rc)
Details
Behat (PHP 7.1)
Details
Behat (PHP 7.2)
Details
Behat (PHP 7.3) Behat (PHP 7.3)
Details
Behat (PHP 7.4-rc)
Details
PHPUnit (PHP 7.3) (lowest dependencies)
Details
PHPUnit (PHP 7.4-rc) (lowest dependencies)
Details
Behat (PHP 7.3) (lowest dependencies)
Details
Behat (PHP 7.4-rc) (lowest dependencies)
Details
PHPUnit (PHP 7.3) (PostgreSQL)
Details
Behat (PHP 7.3) (PostgreSQL)
Details
PHPUnit (PHP 7.3) (MySQL)
Details
Behat (PHP 7.3) (MySQL)
Details
PHPUnit (PHP 7.3) (MongoDB)
Details
Behat (PHP 7.3) (MongoDB)
Details
PHPUnit (PHP 7.3) (Elasticsearch)
Details
Behat (PHP 7.3) (Elasticsearch)
Details
PHPUnit (PHP 7.3) (no deprecations)
Details
PHPUnit (PHP 7.3) (Symfony 4.4)
Details
Behat (PHP 7.3) (Symfony 4.4)
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
Scrutinizer No new issues
Details
SymfonyInsight: dunglas / API Platform Core Code quality OK.
Details
ci/circleci: php-cs-fixer Your tests passed on CircleCI!
Details
ci/circleci: phpstan Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
lint Workflow: lint
Details
@dunglas

This comment has been minimized.

Copy link
Member

dunglas commented Nov 11, 2019

Or just this 😉. Thanks @nicolas-grekas!

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:sf5 branch Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.