From ecd81b74628610c2bd225b23debb20f40ddc420f Mon Sep 17 00:00:00 2001 From: Jade Bellereau Date: Thu, 21 Jan 2021 14:24:03 +0100 Subject: [PATCH 1/4] fix: load swagger even when conf is false --- .../Bundle/DependencyInjection/ApiPlatformExtension.php | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtension.php b/src/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtension.php index 1a351699f3f..f23934e764f 100644 --- a/src/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtension.php +++ b/src/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtension.php @@ -375,10 +375,6 @@ private function registerSwaggerConfiguration(ContainerBuilder $container, array { $container->setParameter('api_platform.swagger.versions', $config['swagger']['versions']); - if (empty($config['swagger']['versions'])) { - return; - } - $loader->load('json_schema.xml'); $loader->load('swagger.xml'); $loader->load('openapi.xml'); From c35c02679efbb35c4e1e2fe8e8ff96fdd0f52d9d Mon Sep 17 00:00:00 2001 From: Jade Bellereau Date: Thu, 21 Jan 2021 14:56:40 +0100 Subject: [PATCH 2/4] fix: change aliases and definitions for swagger disabled in tests --- .../ApiPlatformExtensionTest.php | 68 ++++++++----------- 1 file changed, 30 insertions(+), 38 deletions(-) diff --git a/tests/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtensionTest.php b/tests/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtensionTest.php index c80ee208fa1..83b06277ff8 100644 --- a/tests/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtensionTest.php +++ b/tests/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtensionTest.php @@ -757,12 +757,12 @@ public function testDisabledSwaggerAndHydra() ]; $containerBuilderProphecy = $this->getBaseContainerBuilderProphecy(['orm'], $config); - $containerBuilderProphecy->setDefinition('api_platform.swagger.action.ui', Argument::type(Definition::class))->shouldNotBeCalled(); - $containerBuilderProphecy->setDefinition('api_platform.swagger.listener.ui', Argument::type(Definition::class))->shouldNotBeCalled(); + $containerBuilderProphecy->setDefinition('api_platform.swagger.action.ui', Argument::type(Definition::class))->shouldBeCalled(); + $containerBuilderProphecy->setDefinition('api_platform.swagger.listener.ui', Argument::type(Definition::class))->shouldBeCalled(); $containerBuilderProphecy->setParameter('api_platform.enable_swagger_ui', true)->shouldNotBeCalled(); $containerBuilderProphecy->setParameter('api_platform.enable_swagger_ui', true)->shouldNotBeCalled(); - $containerBuilderProphecy->setParameter('api_platform.enable_swagger_ui', false)->shouldNotBeCalled(); - $containerBuilderProphecy->setParameter('api_platform.enable_re_doc', true)->shouldNotBeCalled(); + $containerBuilderProphecy->setParameter('api_platform.enable_swagger_ui', false)->shouldBeCalled(); + $containerBuilderProphecy->setParameter('api_platform.enable_re_doc', true)->shouldBeCalled(); $containerBuilderProphecy->setParameter('api_platform.enable_re_doc', false)->shouldNotBeCalled(); $containerBuilder = $containerBuilderProphecy->reveal(); $this->extension->load($config, $containerBuilder); @@ -775,13 +775,14 @@ public function testDisabledSwagger() $config['api_platform']['enable_swagger_ui'] = false; $containerBuilderProphecy = $this->getBaseContainerBuilderProphecy(['orm'], $config); - $containerBuilderProphecy->setDefinition('api_platform.swagger.action.ui', Argument::type(Definition::class))->shouldNotBeCalled(); - $containerBuilderProphecy->setDefinition('api_platform.swagger.listener.ui', Argument::type(Definition::class))->shouldNotBeCalled(); - $containerBuilderProphecy->setParameter('api_platform.enable_swagger_ui', true)->shouldNotBeCalled(); + $containerBuilderProphecy->setDefinition('api_platform.swagger.action.ui', Argument::type(Definition::class))->shouldBeCalled(); + $containerBuilderProphecy->setDefinition('api_platform.swagger.listener.ui', Argument::type(Definition::class))->shouldBeCalled(); + $containerBuilderProphecy->setParameter('api_platform.enable_swagger_ui', true)->shouldBeCalled(); $containerBuilderProphecy->setParameter('api_platform.enable_swagger_ui', true)->shouldNotBeCalled(); - $containerBuilderProphecy->setParameter('api_platform.enable_swagger_ui', false)->shouldNotBeCalled(); - $containerBuilderProphecy->setParameter('api_platform.enable_re_doc', true)->shouldNotBeCalled(); + $containerBuilderProphecy->setParameter('api_platform.enable_swagger_ui', false)->shouldBeCalled(); + $containerBuilderProphecy->setParameter('api_platform.enable_re_doc', true)->shouldBeCalled(); $containerBuilderProphecy->setParameter('api_platform.enable_re_doc', false)->shouldNotBeCalled(); + $containerBuilderProphecy->setParameter('api_platform.swagger.api_keys', true)->shouldNotBeCalled(); $containerBuilder = $containerBuilderProphecy->reveal(); $this->extension->load($config, $containerBuilder); } @@ -1167,11 +1168,11 @@ private function getBaseContainerBuilderProphecy(array $doctrineIntegrationsToLo 'api_platform.openapi.contact.email' => null, 'api_platform.openapi.license.name' => null, 'api_platform.openapi.license.url' => null, + 'api_platform.swagger.api_keys' => [], ]; if ($hasSwagger) { $parameters['api_platform.swagger.versions'] = [2, 3]; - $parameters['api_platform.swagger.api_keys'] = []; } else { $parameters['api_platform.swagger.versions'] = []; } @@ -1260,6 +1261,9 @@ private function getBaseContainerBuilderProphecy(array $doctrineIntegrationsToLo 'api_platform.http_cache.listener.response.configure', 'api_platform.http_cache.purger.varnish_client', 'api_platform.http_cache.purger.varnish', + 'api_platform.json_schema.json_schema_generate_command', + 'api_platform.json_schema.schema_factory', + 'api_platform.json_schema.type_factory', 'api_platform.listener.view.validate', 'api_platform.listener.view.validate_query_parameters', 'api_platform.mercure.listener.response.add_link_header', @@ -1282,11 +1286,21 @@ private function getBaseContainerBuilderProphecy(array $doctrineIntegrationsToLo 'api_platform.metadata.resource.name_collection_factory.annotation', 'api_platform.metadata.resource.name_collection_factory.yaml', 'api_platform.metadata.subresource.metadata_factory.annotation', + 'api_platform.openapi.command', + 'api_platform.openapi.factory', + 'api_platform.openapi.normalizer', + 'api_platform.openapi.normalizer.api_gateway', + 'api_platform.openapi.options', 'api_platform.problem.encoder', 'api_platform.problem.normalizer.constraint_violation_list', 'api_platform.problem.normalizer.error', 'api_platform.swagger.action.ui', + 'api_platform.swagger.command.swagger_command', 'api_platform.swagger.listener.ui', + 'api_platform.swagger.normalizer.api_gateway', + 'api_platform.swagger.normalizer.documentation', + 'api_platform.swagger_ui.context', + 'api_platform.swagger_ui.action', 'api_platform.validator', 'api_platform.validator.query_parameter_validator', ]; @@ -1320,22 +1334,6 @@ private function getBaseContainerBuilderProphecy(array $doctrineIntegrationsToLo $definitions[] = 'api_platform.doctrine.metadata_factory'; } - // Only when swagger is enabled - if ($hasSwagger) { - $definitions[] = 'api_platform.swagger.command.swagger_command'; - $definitions[] = 'api_platform.swagger.normalizer.api_gateway'; - $definitions[] = 'api_platform.swagger.normalizer.documentation'; - $definitions[] = 'api_platform.json_schema.type_factory'; - $definitions[] = 'api_platform.json_schema.schema_factory'; - $definitions[] = 'api_platform.json_schema.json_schema_generate_command'; - $definitions[] = 'api_platform.openapi.options'; - $definitions[] = 'api_platform.openapi.normalizer'; - $definitions[] = 'api_platform.openapi.normalizer.api_gateway'; - $definitions[] = 'api_platform.openapi.factory'; - $definitions[] = 'api_platform.openapi.command'; - $definitions[] = 'api_platform.swagger_ui.context'; - $definitions[] = 'api_platform.swagger_ui.action'; - } // has jsonld if ($hasHydra) { @@ -1369,11 +1367,15 @@ private function getBaseContainerBuilderProphecy(array $doctrineIntegrationsToLo $aliases = [ 'api_platform.http_cache.purger' => 'api_platform.http_cache.purger.varnish', 'api_platform.message_bus' => 'messenger.default_bus', + 'api_platform.swagger_ui.listener' => 'api_platform.swagger.listener.ui', EagerLoadingExtension::class => 'api_platform.doctrine.orm.query_extension.eager_loading', FilterExtension::class => 'api_platform.doctrine.orm.query_extension.filter', FilterEagerLoadingExtension::class => 'api_platform.doctrine.orm.query_extension.filter_eager_loading', PaginationExtension::class => 'api_platform.doctrine.orm.query_extension.pagination', OrderExtension::class => 'api_platform.doctrine.orm.query_extension.order', + SchemaFactoryInterface::class => 'api_platform.json_schema.schema_factory', + OpenApiFactoryInterface::class => 'api_platform.openapi.factory', + TypeFactoryInterface::class => 'api_platform.json_schema.type_factory', ValidatorInterface::class => 'api_platform.validator', SearchFilter::class => 'api_platform.doctrine.orm.search_filter', OrderFilter::class => 'api_platform.doctrine.orm.order_filter', @@ -1383,6 +1385,8 @@ private function getBaseContainerBuilderProphecy(array $doctrineIntegrationsToLo NumericFilter::class => 'api_platform.doctrine.orm.numeric_filter', ExistsFilter::class => 'api_platform.doctrine.orm.exists_filter', GraphQlSerializerContextBuilderInterface::class => 'api_platform.graphql.serializer.context_builder', + OpenApiNormalizer::class => 'api_platform.openapi.normalizer', + Options::class => 'api_platform.openapi.options', ]; if (\in_array('odm', $doctrineIntegrationsToLoad, true)) { @@ -1400,18 +1404,6 @@ private function getBaseContainerBuilderProphecy(array $doctrineIntegrationsToLo ]; } - // Only when swagger is enabled - if ($hasSwagger) { - $aliases += [ - TypeFactoryInterface::class => 'api_platform.json_schema.type_factory', - SchemaFactoryInterface::class => 'api_platform.json_schema.schema_factory', - Options::class => 'api_platform.openapi.options', - OpenApiNormalizer::class => 'api_platform.openapi.normalizer', - OpenApiFactoryInterface::class => 'api_platform.openapi.factory', - 'api_platform.swagger_ui.listener' => 'api_platform.swagger.listener.ui', - ]; - } - foreach ($aliases as $alias => $service) { $containerBuilderProphecy->setAlias($alias, $service)->shouldBeCalled(); } From f3be2c14fb47500fae0d288e69ca28487d210b52 Mon Sep 17 00:00:00 2001 From: Jade Bellereau Date: Fri, 22 Jan 2021 11:05:47 +0100 Subject: [PATCH 3/4] fix: manage necessary services loading --- .../ApiPlatformExtension.php | 11 +++- .../Symfony/Bundle/Resources/config/api.xml | 2 +- .../ApiPlatformExtensionTest.php | 66 +++++++++++-------- 3 files changed, 48 insertions(+), 31 deletions(-) diff --git a/src/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtension.php b/src/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtension.php index f23934e764f..86d10faa51a 100644 --- a/src/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtension.php +++ b/src/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtension.php @@ -375,9 +375,18 @@ private function registerSwaggerConfiguration(ContainerBuilder $container, array { $container->setParameter('api_platform.swagger.versions', $config['swagger']['versions']); + if (!$config['enable_swagger'] && $config['enable_swagger_ui']) { + throw new RuntimeException('Unsupported configuration with enable_swagger: false and enable_swagger_ui: true'); + } + $loader->load('json_schema.xml'); - $loader->load('swagger.xml'); + + if (!$config['enable_swagger']) { + return; + } + $loader->load('openapi.xml'); + $loader->load('swagger.xml'); $loader->load('swagger-ui.xml'); if (!$config['enable_swagger_ui'] && !$config['enable_re_doc']) { diff --git a/src/Bridge/Symfony/Bundle/Resources/config/api.xml b/src/Bridge/Symfony/Bundle/Resources/config/api.xml index 3590f964d42..cb4bf137755 100644 --- a/src/Bridge/Symfony/Bundle/Resources/config/api.xml +++ b/src/Bridge/Symfony/Bundle/Resources/config/api.xml @@ -242,7 +242,7 @@ %api_platform.version% null %api_platform.swagger.versions% - + diff --git a/tests/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtensionTest.php b/tests/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtensionTest.php index 83b06277ff8..61f1e4545cb 100644 --- a/tests/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtensionTest.php +++ b/tests/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtensionTest.php @@ -757,12 +757,12 @@ public function testDisabledSwaggerAndHydra() ]; $containerBuilderProphecy = $this->getBaseContainerBuilderProphecy(['orm'], $config); - $containerBuilderProphecy->setDefinition('api_platform.swagger.action.ui', Argument::type(Definition::class))->shouldBeCalled(); - $containerBuilderProphecy->setDefinition('api_platform.swagger.listener.ui', Argument::type(Definition::class))->shouldBeCalled(); + $containerBuilderProphecy->setDefinition('api_platform.swagger.action.ui', Argument::type(Definition::class))->shouldNotBeCalled(); + $containerBuilderProphecy->setDefinition('api_platform.swagger.listener.ui', Argument::type(Definition::class))->shouldNotBeCalled(); $containerBuilderProphecy->setParameter('api_platform.enable_swagger_ui', true)->shouldNotBeCalled(); $containerBuilderProphecy->setParameter('api_platform.enable_swagger_ui', true)->shouldNotBeCalled(); - $containerBuilderProphecy->setParameter('api_platform.enable_swagger_ui', false)->shouldBeCalled(); - $containerBuilderProphecy->setParameter('api_platform.enable_re_doc', true)->shouldBeCalled(); + $containerBuilderProphecy->setParameter('api_platform.enable_swagger_ui', false)->shouldNotBeCalled(); + $containerBuilderProphecy->setParameter('api_platform.enable_re_doc', true)->shouldNotBeCalled(); $containerBuilderProphecy->setParameter('api_platform.enable_re_doc', false)->shouldNotBeCalled(); $containerBuilder = $containerBuilderProphecy->reveal(); $this->extension->load($config, $containerBuilder); @@ -775,14 +775,13 @@ public function testDisabledSwagger() $config['api_platform']['enable_swagger_ui'] = false; $containerBuilderProphecy = $this->getBaseContainerBuilderProphecy(['orm'], $config); - $containerBuilderProphecy->setDefinition('api_platform.swagger.action.ui', Argument::type(Definition::class))->shouldBeCalled(); - $containerBuilderProphecy->setDefinition('api_platform.swagger.listener.ui', Argument::type(Definition::class))->shouldBeCalled(); - $containerBuilderProphecy->setParameter('api_platform.enable_swagger_ui', true)->shouldBeCalled(); + $containerBuilderProphecy->setDefinition('api_platform.swagger.action.ui', Argument::type(Definition::class))->shouldNotBeCalled(); + $containerBuilderProphecy->setDefinition('api_platform.swagger.listener.ui', Argument::type(Definition::class))->shouldNotBeCalled(); + $containerBuilderProphecy->setParameter('api_platform.enable_swagger_ui', true)->shouldNotBeCalled(); $containerBuilderProphecy->setParameter('api_platform.enable_swagger_ui', true)->shouldNotBeCalled(); - $containerBuilderProphecy->setParameter('api_platform.enable_swagger_ui', false)->shouldBeCalled(); - $containerBuilderProphecy->setParameter('api_platform.enable_re_doc', true)->shouldBeCalled(); + $containerBuilderProphecy->setParameter('api_platform.enable_swagger_ui', false)->shouldNotBeCalled(); + $containerBuilderProphecy->setParameter('api_platform.enable_re_doc', true)->shouldNotBeCalled(); $containerBuilderProphecy->setParameter('api_platform.enable_re_doc', false)->shouldNotBeCalled(); - $containerBuilderProphecy->setParameter('api_platform.swagger.api_keys', true)->shouldNotBeCalled(); $containerBuilder = $containerBuilderProphecy->reveal(); $this->extension->load($config, $containerBuilder); } @@ -1168,11 +1167,11 @@ private function getBaseContainerBuilderProphecy(array $doctrineIntegrationsToLo 'api_platform.openapi.contact.email' => null, 'api_platform.openapi.license.name' => null, 'api_platform.openapi.license.url' => null, - 'api_platform.swagger.api_keys' => [], ]; if ($hasSwagger) { $parameters['api_platform.swagger.versions'] = [2, 3]; + $parameters['api_platform.swagger.api_keys'] = []; } else { $parameters['api_platform.swagger.versions'] = []; } @@ -1262,8 +1261,8 @@ private function getBaseContainerBuilderProphecy(array $doctrineIntegrationsToLo 'api_platform.http_cache.purger.varnish_client', 'api_platform.http_cache.purger.varnish', 'api_platform.json_schema.json_schema_generate_command', - 'api_platform.json_schema.schema_factory', 'api_platform.json_schema.type_factory', + 'api_platform.json_schema.schema_factory', 'api_platform.listener.view.validate', 'api_platform.listener.view.validate_query_parameters', 'api_platform.mercure.listener.response.add_link_header', @@ -1286,21 +1285,11 @@ private function getBaseContainerBuilderProphecy(array $doctrineIntegrationsToLo 'api_platform.metadata.resource.name_collection_factory.annotation', 'api_platform.metadata.resource.name_collection_factory.yaml', 'api_platform.metadata.subresource.metadata_factory.annotation', - 'api_platform.openapi.command', - 'api_platform.openapi.factory', - 'api_platform.openapi.normalizer', - 'api_platform.openapi.normalizer.api_gateway', - 'api_platform.openapi.options', 'api_platform.problem.encoder', 'api_platform.problem.normalizer.constraint_violation_list', 'api_platform.problem.normalizer.error', 'api_platform.swagger.action.ui', - 'api_platform.swagger.command.swagger_command', 'api_platform.swagger.listener.ui', - 'api_platform.swagger.normalizer.api_gateway', - 'api_platform.swagger.normalizer.documentation', - 'api_platform.swagger_ui.context', - 'api_platform.swagger_ui.action', 'api_platform.validator', 'api_platform.validator.query_parameter_validator', ]; @@ -1334,7 +1323,20 @@ private function getBaseContainerBuilderProphecy(array $doctrineIntegrationsToLo $definitions[] = 'api_platform.doctrine.metadata_factory'; } - + // Only when swagger is enabled + if ($hasSwagger) { + $definitions[] = 'api_platform.swagger.command.swagger_command'; + $definitions[] = 'api_platform.swagger.normalizer.api_gateway'; + $definitions[] = 'api_platform.swagger.normalizer.documentation'; + $definitions[] = 'api_platform.openapi.options'; + $definitions[] = 'api_platform.openapi.normalizer'; + $definitions[] = 'api_platform.openapi.normalizer.api_gateway'; + $definitions[] = 'api_platform.openapi.factory'; + $definitions[] = 'api_platform.openapi.command'; + $definitions[] = 'api_platform.swagger_ui.context'; + $definitions[] = 'api_platform.swagger_ui.action'; + } + // has jsonld if ($hasHydra) { $containerBuilderProphecy->has('api_platform.json_schema.schema_factory')->shouldBeCalled()->willReturn($hasSwagger); @@ -1367,15 +1369,11 @@ private function getBaseContainerBuilderProphecy(array $doctrineIntegrationsToLo $aliases = [ 'api_platform.http_cache.purger' => 'api_platform.http_cache.purger.varnish', 'api_platform.message_bus' => 'messenger.default_bus', - 'api_platform.swagger_ui.listener' => 'api_platform.swagger.listener.ui', EagerLoadingExtension::class => 'api_platform.doctrine.orm.query_extension.eager_loading', FilterExtension::class => 'api_platform.doctrine.orm.query_extension.filter', FilterEagerLoadingExtension::class => 'api_platform.doctrine.orm.query_extension.filter_eager_loading', PaginationExtension::class => 'api_platform.doctrine.orm.query_extension.pagination', OrderExtension::class => 'api_platform.doctrine.orm.query_extension.order', - SchemaFactoryInterface::class => 'api_platform.json_schema.schema_factory', - OpenApiFactoryInterface::class => 'api_platform.openapi.factory', - TypeFactoryInterface::class => 'api_platform.json_schema.type_factory', ValidatorInterface::class => 'api_platform.validator', SearchFilter::class => 'api_platform.doctrine.orm.search_filter', OrderFilter::class => 'api_platform.doctrine.orm.order_filter', @@ -1385,8 +1383,8 @@ private function getBaseContainerBuilderProphecy(array $doctrineIntegrationsToLo NumericFilter::class => 'api_platform.doctrine.orm.numeric_filter', ExistsFilter::class => 'api_platform.doctrine.orm.exists_filter', GraphQlSerializerContextBuilderInterface::class => 'api_platform.graphql.serializer.context_builder', - OpenApiNormalizer::class => 'api_platform.openapi.normalizer', - Options::class => 'api_platform.openapi.options', + TypeFactoryInterface::class => 'api_platform.json_schema.type_factory', + SchemaFactoryInterface::class => 'api_platform.json_schema.schema_factory', ]; if (\in_array('odm', $doctrineIntegrationsToLoad, true)) { @@ -1404,6 +1402,16 @@ private function getBaseContainerBuilderProphecy(array $doctrineIntegrationsToLo ]; } + // Only when swagger is enabled + if ($hasSwagger) { + $aliases += [ + Options::class => 'api_platform.openapi.options', + OpenApiNormalizer::class => 'api_platform.openapi.normalizer', + OpenApiFactoryInterface::class => 'api_platform.openapi.factory', + 'api_platform.swagger_ui.listener' => 'api_platform.swagger.listener.ui', + ]; + } + foreach ($aliases as $alias => $service) { $containerBuilderProphecy->setAlias($alias, $service)->shouldBeCalled(); } From e0a8d4aa3cab878a038d2c9d608f96b401d31e2b Mon Sep 17 00:00:00 2001 From: Jade Bellereau Date: Wed, 27 Jan 2021 09:49:24 +0100 Subject: [PATCH 4/4] fix typo --- .../Symfony/Bundle/DependencyInjection/ApiPlatformExtension.php | 2 +- .../Bundle/DependencyInjection/ApiPlatformExtensionTest.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtension.php b/src/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtension.php index 86d10faa51a..c330c90905f 100644 --- a/src/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtension.php +++ b/src/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtension.php @@ -376,7 +376,7 @@ private function registerSwaggerConfiguration(ContainerBuilder $container, array $container->setParameter('api_platform.swagger.versions', $config['swagger']['versions']); if (!$config['enable_swagger'] && $config['enable_swagger_ui']) { - throw new RuntimeException('Unsupported configuration with enable_swagger: false and enable_swagger_ui: true'); + throw new RuntimeException('You can not enable the Swagger UI without enabling Swagger, fix this by enabling swagger via the configuration "enable_swagger: true".'); } $loader->load('json_schema.xml'); diff --git a/tests/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtensionTest.php b/tests/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtensionTest.php index 61f1e4545cb..96c0fea8597 100644 --- a/tests/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtensionTest.php +++ b/tests/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtensionTest.php @@ -1336,7 +1336,7 @@ private function getBaseContainerBuilderProphecy(array $doctrineIntegrationsToLo $definitions[] = 'api_platform.swagger_ui.context'; $definitions[] = 'api_platform.swagger_ui.action'; } - + // has jsonld if ($hasHydra) { $containerBuilderProphecy->has('api_platform.json_schema.schema_factory')->shouldBeCalled()->willReturn($hasSwagger);