Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hydra:previous to the hydra view schema properties #4310

Merged
merged 1 commit into from
Jun 15, 2021

Conversation

coudenysj
Copy link
Contributor

Q A
Branch? main
License MIT

I don't know if this is intentional, but the hydra:previous property is not in the SchemaFactory (rendering the openapi specs incomplete).

@alanpoulain
Copy link
Member

Hello,
It should target 2.6 and you should have at least a unit test, but I think it is not intentional. @soyuka WDYT?

@coudenysj coudenysj changed the base branch from main to 2.6 June 8, 2021 12:56
@coudenysj coudenysj changed the base branch from 2.6 to main June 8, 2021 12:57
@coudenysj coudenysj changed the base branch from main to 2.6 June 8, 2021 12:59
@coudenysj coudenysj force-pushed the hydra-view-previous branch 2 times, most recently from f65fb61 to b6300a8 Compare June 8, 2021 13:45
@coudenysj
Copy link
Contributor Author

2.6 is the target now and added a unit test.

@alanpoulain
Copy link
Member

Some Behat tests need to be fixed too.

@coudenysj
Copy link
Contributor Author

Behat fix has been added, I don't think the remaining errors have to do with my changes.

@dunglas dunglas merged commit 9781658 into api-platform:2.6 Jun 15, 2021
@dunglas
Copy link
Member

dunglas commented Jun 15, 2021

Good catch, thank you @coudenysj!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants