From f6247b973ac5cf2adc80fbc6b5d3b3cd0c690f5b Mon Sep 17 00:00:00 2001
From: Danny van Wijk <dannyvanwijk@gmail.com>
Date: Tue, 17 May 2022 22:57:31 +0200
Subject: [PATCH] fix(metadata): add read and write to extractor

---
 src/Metadata/Extractor/XmlResourceExtractor.php  | 2 ++
 src/Metadata/Extractor/YamlResourceExtractor.php | 2 ++
 tests/Metadata/Extractor/XmlExtractorTest.php    | 4 ++++
 tests/Metadata/Extractor/YamlExtractorTest.php   | 8 ++++++++
 4 files changed, 16 insertions(+)

diff --git a/src/Metadata/Extractor/XmlResourceExtractor.php b/src/Metadata/Extractor/XmlResourceExtractor.php
index 534d453eb01..35b83cd9aea 100644
--- a/src/Metadata/Extractor/XmlResourceExtractor.php
+++ b/src/Metadata/Extractor/XmlResourceExtractor.php
@@ -128,6 +128,8 @@ private function buildBase(\SimpleXMLElement $resource): array
             'filters' => $this->buildArrayValue($resource, 'filter'),
             'order' => isset($resource->order->values) ? $this->buildValues($resource->order->values) : null,
             'extraProperties' => $this->buildExtraProperties($resource, 'extraProperties'),
+            'read' => $this->phpize($resource, 'read', 'bool'),
+            'write' => $this->phpize($resource, 'write', 'bool'),
         ];
     }
 
diff --git a/src/Metadata/Extractor/YamlResourceExtractor.php b/src/Metadata/Extractor/YamlResourceExtractor.php
index 37e24681950..c2473369807 100644
--- a/src/Metadata/Extractor/YamlResourceExtractor.php
+++ b/src/Metadata/Extractor/YamlResourceExtractor.php
@@ -157,6 +157,8 @@ private function buildBase(array $resource): array
             'extraProperties' => $this->buildArrayValue($resource, 'extraProperties'),
             'mercure' => $this->buildMercure($resource),
             'messenger' => $this->buildMessenger($resource),
+            'read' => $this->phpize($resource, 'read', 'bool'),
+            'write' => $this->phpize($resource, 'write', 'bool'),
         ];
     }
 
diff --git a/tests/Metadata/Extractor/XmlExtractorTest.php b/tests/Metadata/Extractor/XmlExtractorTest.php
index 75860e95887..3796f14cd8e 100644
--- a/tests/Metadata/Extractor/XmlExtractorTest.php
+++ b/tests/Metadata/Extractor/XmlExtractorTest.php
@@ -95,6 +95,8 @@ public function testValidXML(): void
                     'class' => Comment::class,
                     'processor' => null,
                     'provider' => null,
+                    'read' => null,
+                    'write' => null,
                 ],
                 [
                     'uriTemplate' => '/users/{author}/comments.{_format}',
@@ -358,6 +360,8 @@ public function testValidXML(): void
                     'class' => Comment::class,
                     'processor' => null,
                     'provider' => null,
+                    'read' => null,
+                    'write' => null,
                 ],
             ],
         ], $extractor->getResources());
diff --git a/tests/Metadata/Extractor/YamlExtractorTest.php b/tests/Metadata/Extractor/YamlExtractorTest.php
index e58451d2ebb..3cbacb71577 100644
--- a/tests/Metadata/Extractor/YamlExtractorTest.php
+++ b/tests/Metadata/Extractor/YamlExtractorTest.php
@@ -95,6 +95,8 @@ public function testValidYaml(): void
                     'graphQlOperations' => null,
                     'processor' => null,
                     'provider' => null,
+                    'read' => null,
+                    'write' => null,
                 ],
             ],
             Program::class => [
@@ -160,6 +162,8 @@ public function testValidYaml(): void
                     'graphQlOperations' => null,
                     'processor' => null,
                     'provider' => null,
+                    'read' => null,
+                    'write' => null,
                 ],
                 [
                     'uriTemplate' => '/users/{author}/programs.{_format}',
@@ -367,6 +371,8 @@ public function testValidYaml(): void
                     'graphQlOperations' => null,
                     'processor' => null,
                     'provider' => null,
+                    'read' => null,
+                    'write' => null,
                 ],
             ],
             SingleFileConfigDummy::class => [
@@ -432,6 +438,8 @@ public function testValidYaml(): void
                     'graphQlOperations' => null,
                     'processor' => null,
                     'provider' => null,
+                    'read' => null,
+                    'write' => null,
                 ],
             ],
         ], $extractor->getResources());