From 039db9f132980898bcb2cd9bb4f9edcf4465c9fa Mon Sep 17 00:00:00 2001 From: Antoine Bluchet Date: Fri, 21 Apr 2023 15:56:23 +0200 Subject: [PATCH] Revert "fix(symfony): query parameter validation after authentication (#5473)" This reverts commit 42c5c3e6466cc546db2325f5e8a9c09ead5453e2. --- .../deny_authentication_before_filter.feature | 11 ----- .../Resources/config/symfony/validator.xml | 2 +- .../Entity/SecuredDummyWithFilter.php | 41 ------------------- 3 files changed, 1 insertion(+), 53 deletions(-) delete mode 100644 features/authorization/deny_authentication_before_filter.feature delete mode 100644 tests/Fixtures/TestBundle/Entity/SecuredDummyWithFilter.php diff --git a/features/authorization/deny_authentication_before_filter.feature b/features/authorization/deny_authentication_before_filter.feature deleted file mode 100644 index a636383b7ab..00000000000 --- a/features/authorization/deny_authentication_before_filter.feature +++ /dev/null @@ -1,11 +0,0 @@ -Feature: Authorization checking - In order to use the API - I need to be authorized to access a given resource. - - @!mongodb - @createSchema - Scenario: An anonymous user retrieves a secured resource - When I add "Accept" header equal to "application/ld+json" - When I am on "/secured_dummy_with_filters?required=&required-allow-empty=&arrayRequired[foo]=" - Then the response status code should be 401 - diff --git a/src/Symfony/Bundle/Resources/config/symfony/validator.xml b/src/Symfony/Bundle/Resources/config/symfony/validator.xml index a7d402db4b7..912757c247d 100644 --- a/src/Symfony/Bundle/Resources/config/symfony/validator.xml +++ b/src/Symfony/Bundle/Resources/config/symfony/validator.xml @@ -27,7 +27,7 @@ %api_platform.validator.query_parameter_validation% - + diff --git a/tests/Fixtures/TestBundle/Entity/SecuredDummyWithFilter.php b/tests/Fixtures/TestBundle/Entity/SecuredDummyWithFilter.php deleted file mode 100644 index a59f4438b3a..00000000000 --- a/tests/Fixtures/TestBundle/Entity/SecuredDummyWithFilter.php +++ /dev/null @@ -1,41 +0,0 @@ - - * - * For the full copyright and license information, please view the LICENSE - * file that was distributed with this source code. - */ - -declare(strict_types=1); - -namespace ApiPlatform\Tests\Fixtures\TestBundle\Entity; - -use ApiPlatform\Metadata\ApiResource; -use ApiPlatform\Tests\Fixtures\TestBundle\Filter\ArrayRequiredFilter; -use Doctrine\ORM\Mapping as ORM; - -/** - * Secured resource. - * - * @author Kévin Dunglas - */ -#[ApiResource( - security: 'is_granted(\'ROLE_USER\')', - filters: [ArrayRequiredFilter::class], -)] -#[ORM\Entity] -class SecuredDummyWithFilter -{ - #[ORM\Column(type: 'integer')] - #[ORM\Id] - #[ORM\GeneratedValue(strategy: 'AUTO')] - private ?int $id = null; - - public function getId(): ?int - { - return $this->id; - } -}