Update dependencies for building the PHAR #124
Conversation
theofidry
force-pushed
the
bugfix/phar
branch
from
5cda451
to
192ca9f
Compare
| - if [[ $coverage = 1 ]]; then mkdir -p build/logs; fi | ||
| - if [[ $coverage = 1 ]]; then wget https://github.com/satooshi/php-coveralls/releases/download/v2.0.0/php-coveralls.phar; fi | ||
| - if [[ $lint = 1 ]]; then wget https://github.com/FriendsOfPHP/PHP-CS-Fixer/releases/download/v2.10.0/php-cs-fixer.phar; fi | ||
| - if [[ $lint = 1 ]]; then composer global require --dev 'phpstan/phpstan:^0.8'; fi | ||
| - if [[ ! $deps && $TRAVIS_PHP_VERSION = "7.2" ]]; then curl -LSs https://box-project.github.io/box2/installer.php | php; fi; | ||
| - wget -O box.phar https://github.com/humbug/box/releases/download/3.1.3/box.phar | ||
| - export BOX_BIN=$(pwd)/box.phar |
There was a problem hiding this comment.
we export BOX_BIN here because the shell script uses that environment variable. It's also conveniently allows one to switch to another bin locally, e.g. myself to switch to my current box binary directly from the humbug/box project.
| @@ -1,31 +0,0 @@ | |||
| { | |||
There was a problem hiding this comment.
Nothing wrong with the file itself but I think it's a better practice to have a .dist to allow one to use the non .dist file locally for testing his stuff
| @@ -0,0 +1,33 @@ | |||
| { | |||
| "banner": [ | |||
There was a problem hiding this comment.
there was no banner previously, up to you if you want one or if you want to remove it
|
PR ready for review, the failure seems unrelated but I think it would be better to rebase & merge this one after #142 |
theofidry
force-pushed
the
bugfix/phar
branch
from
956337a
to
1e621e2
Compare
theofidry
force-pushed
the
bugfix/phar
branch
from
b88212a
to
f2b3d2a
Compare
|
@dunglas ready for review |
|
Thank you very much @theofidry |
Attempt to udpate PHP-Scoper and switch from the unmaintained Box2 to Humbug Box A.K.A Box 3.
It's not going as well as I hoped mostly because Easy_Rdf is using a weird PSR-0 setup which PHP-Scoper is not able to convert correctly to PSR-4.