Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling multiple version #103

Open
wants to merge 12 commits into
base: master
from

Conversation

Projects
None yet
6 participants
@GregoireHebert
Copy link
Contributor

commented Apr 7, 2019

This allow to use different version of the documentation according to the api-plaform/docs branches

  • Add a selector to change the version.

GregoireHebert added some commits Apr 7, 2019

@GregoireHebert GregoireHebert changed the title [WIP] Multiple version Handling multiple version Apr 11, 2019

@GregoireHebert

This comment has been minimized.

Copy link
Contributor Author

commented Apr 11, 2019

I feel like this PR is ready. But is there something we should take care of before, regarding the search system?

Show resolved Hide resolved bin/check-outline Outdated
Show resolved Hide resolved bin/checkout-documentation Outdated
Show resolved Hide resolved bin/checkout-documentation Outdated
Show resolved Hide resolved bin/checkout-documentation Outdated
Show resolved Hide resolved bin/checkout-documentation Outdated
Show resolved Hide resolved bin/generate-nav Outdated
Show resolved Hide resolved bin/generate-nav Outdated
Show resolved Hide resolved bin/retrieve-documentation Outdated
Show resolved Hide resolved gatsby-node.js Outdated

GregoireHebert added some commits Apr 12, 2019

@alanpoulain
Copy link
Member

left a comment

LGTM. Shall we merge it or are we waiting for another review?

@GregoireHebert

This comment has been minimized.

Copy link
Contributor Author

commented Apr 14, 2019

Wanna ping someone?
I am still unsure about the search with algolia

@soyuka

soyuka approved these changes Apr 15, 2019

@dunglas
Copy link
Member

left a comment

We need to make some SEO-related changes before merging this:

We must keep the current URLs, without redirection (don't add /stable/ in the URL)
All "versioned" URLs should be in noindex to prevent them to show up in Google, and to prevent duplicate content.
They must also contain a canonical link pointing to the "main" (the stable) page, if it exists.

Show resolved Hide resolved constants.js Outdated
Show resolved Hide resolved bin/checkout-documentation Outdated
Show resolved Hide resolved bin/generate-nav Outdated
Show resolved Hide resolved bin/generate-nav Outdated
Show resolved Hide resolved gatsby-node.js Outdated
Show resolved Hide resolved bin/generate-nav Outdated
Show resolved Hide resolved gatsby-node.js Outdated
Show resolved Hide resolved gatsby-node.js Outdated
Show resolved Hide resolved gatsby-node.js Outdated
Show resolved Hide resolved src/styles/components/_docs.scss Outdated
Show resolved Hide resolved src/styles/components/_docs.scss Outdated

GregoireHebert added some commits Apr 20, 2019

@GregoireHebert

This comment has been minimized.

Copy link
Contributor Author

commented Apr 20, 2019

still need to add the noindex meta on other versions.

@GregoireHebert

This comment has been minimized.

Copy link
Contributor Author

commented Apr 21, 2019

As I was looking for other solution than noindex.
https://tools.ietf.org/html/rfc6596#section-3 tells us it is only to be used for duplicate or supersets.
Which is not quite the case. WDYT? @dunglas

@GregoireHebert GregoireHebert force-pushed the GregoireHebert:multiple-version branch from 938634b to 7abed8b Apr 22, 2019

@GregoireHebert

This comment has been minimized.

Copy link
Contributor Author

commented Apr 22, 2019

RFR.
I handled properly most of the comments. Some have been purposely ignored, or did in another way.
I am opened to discussion.

@toofff

toofff approved these changes Apr 24, 2019

@GregoireHebert

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2019

ping @dunglas :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.