This repository was archived by the owner on Nov 8, 2024. It is now read-only.
chore(project): added coveralls #280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylef
approved these changes
Jul 11, 2019
.circleci/config.yml
Outdated
| - test-smoke | ||
| - test-smoke: | ||
| requires: | ||
| - test-node12 |
Member
There was a problem hiding this comment.
IMO, I wouldn't depend test-node12, this delays running smoke tests (which are a little slow as it builds Protagonist) by 30 more seconds. Earlier we start running test-smoke the sooner it finishes.
kylef
approved these changes
Jul 11, 2019
pksunkara
force-pushed
the
pksunkara/cover
branch
from
0338ab5 to
c5730cd
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #270
This commit has been uploaded to https://coveralls.io/github/apiaryio/api-elements.js