New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add integration for Rust hooks #833

Merged
merged 1 commit into from Aug 10, 2017

Conversation

Projects
None yet
2 participants
@hobofan
Contributor

hobofan commented Aug 1, 2017

Hey there! 馃憢

I wrote a hooks-handler for Rust: https://github.com/hobofan/dredd-hooks-rust.

This PR adds all the additional parts on the Dredd side that make a hooks integration more pleasant to use, similar to the other languages. I closely followed the Go integration, so I hope I didn't miss anything. The only thing I know that is missing is the Rust logo in the README, which I hope is okay for now.

Looking forward to your feedback!

@honzajavorek

This comment has been minimized.

Show comment
Hide comment
@honzajavorek

honzajavorek Aug 2, 2017

Member

This is amazing! @hobofan 馃憦 馃憦 馃憦 It will take me some time to go through the changes, but in advance, thanks for all the work! Don't worry about the image, we'll ask @tjerabek to get a new one 馃槃

Member

honzajavorek commented Aug 2, 2017

This is amazing! @hobofan 馃憦 馃憦 馃憦 It will take me some time to go through the changes, but in advance, thanks for all the work! Don't worry about the image, we'll ask @tjerabek to get a new one 馃槃

@honzajavorek

This comment has been minimized.

Show comment
Hide comment
@honzajavorek

honzajavorek Aug 7, 2017

Member

Just to let you know, I'm on it, but I've got carried away by investigation of #834.

However, I already asked for the new image with Rust logo added 馃槈

Member

honzajavorek commented Aug 7, 2017

Just to let you know, I'm on it, but I've got carried away by investigation of #834.

However, I already asked for the new image with Rust logo added 馃槈

@hobofan

This comment has been minimized.

Show comment
Hide comment
@hobofan

hobofan Aug 7, 2017

Contributor

However, I already asked for the new image with Rust logo added聽馃槈

Thanks! :)

Contributor

hobofan commented Aug 7, 2017

However, I already asked for the new image with Rust logo added聽馃槈

Thanks! :)

@honzajavorek

honzajavorek approved these changes Aug 8, 2017 edited

Just did review of this PR and it is absolutely wonderful 鉂わ笍 I think we can merge this!

One question - does your rust hooks repo feature a CI (like Travis CI), which would make sure the tests, especially the ones from the dredd hooks template, are passing? Without it, I'm still 5% hesitant to add direct integration to Dredd, but with the CI the hesitation would be erased and it would be 100% accepted 馃槑

@hobofan

This comment has been minimized.

Show comment
Hide comment
@hobofan

hobofan Aug 8, 2017

Contributor

Not yet. After opening this PR, the first thing I did was integrating the dredd hooks template test suite and get it running, but I haven't set up Travis for it yet. Will do so ASAP.

Contributor

hobofan commented Aug 8, 2017

Not yet. After opening this PR, the first thing I did was integrating the dredd hooks template test suite and get it running, but I haven't set up Travis for it yet. Will do so ASAP.

@hobofan hobofan referenced this pull request Aug 8, 2017

Closed

Set up Travis #5

@hobofan

This comment has been minimized.

Show comment
Hide comment
@hobofan

hobofan Aug 10, 2017

Contributor

@honzajavorek
I added Travis CI with the test harness in hobofan/dredd-hooks-rust#6.

Contributor

hobofan commented Aug 10, 2017

@honzajavorek
I added Travis CI with the test harness in hobofan/dredd-hooks-rust#6.

@honzajavorek

This comment has been minimized.

Show comment
Hide comment
@honzajavorek

honzajavorek Aug 10, 2017

Member

@hobofan awesome! 馃帀

Member

honzajavorek commented Aug 10, 2017

@hobofan awesome! 馃帀

@honzajavorek honzajavorek merged commit c2272e2 into apiaryio:master Aug 10, 2017

4 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.1%) to 96.105%
Details
security/snyk No new vulnerabilities
Details
@hobofan

This comment has been minimized.

Show comment
Hide comment
@hobofan

hobofan Aug 10, 2017

Contributor

馃帀 Yay! Thanks @honzajavorek and @tjerabek for the smooth process! :)

Contributor

hobofan commented Aug 10, 2017

馃帀 Yay! Thanks @honzajavorek and @tjerabek for the smooth process! :)

@honzajavorek

This comment has been minimized.

Show comment
Hide comment
@honzajavorek

honzajavorek Aug 10, 2017

Member

@hobofan I think you deserve all the praise, for contributing the Rust hooks 馃槃 It's so great. Thanks very much 馃憤

Member

honzajavorek commented Aug 10, 2017

@hobofan I think you deserve all the praise, for contributing the Rust hooks 馃槃 It's so great. Thanks very much 馃憤

@honzajavorek

This comment has been minimized.

Show comment
Hide comment
@honzajavorek

honzajavorek Aug 10, 2017

Member

Just an update, this didn't get released yet, because of #854, but the docs are built and up to date, so Dredd now features the how-to and Rust logo.

Member

honzajavorek commented Aug 10, 2017

Just an update, this didn't get released yet, because of #854, but the docs are built and up to date, so Dredd now features the how-to and Rust logo.

@hobofan

This comment has been minimized.

Show comment
Hide comment
@hobofan

hobofan Aug 10, 2017

Contributor

I'm not in a rush ;)

Contributor

hobofan commented Aug 10, 2017

I'm not in a rush ;)

@honzajavorek

This comment has been minimized.

Show comment
Hide comment
@honzajavorek

honzajavorek Aug 11, 2017

Member

Finally, v4.2.0!

Member

honzajavorek commented Aug 11, 2017

Finally, v4.2.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment