New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GOPATH if GOBIN isn't set #928

Merged
merged 4 commits into from Dec 1, 2017

Conversation

Projects
None yet
5 participants
@honzajavorek
Member

honzajavorek commented Nov 29, 2017

πŸš€ Why this change?

According to Go docs, the following cascade should be the correct way to determine where to look for the binaries:

  • $GOBIN
  • $GOPATH/bin
  • $(go env GOPATH)/bin

Review from @ddelnano / @snikch appreciated. I'm also adding all the Go fans I know as reviewers, because I'm not really skilled in Go at all.

πŸ“ Related issues and Pull Requests

βœ… What didn't I forget?

  • To write docs
  • To write tests
  • To put Conventional Changelog prefixes in front of all my commits and run npm run lint
@snikch

This comment has been minimized.

Show comment
Hide comment
@snikch

snikch Nov 29, 2017

Contributor

Makes sense to me.

Contributor

snikch commented Nov 29, 2017

Makes sense to me.

@ddelnano

This comment has been minimized.

Show comment
Hide comment
@ddelnano

ddelnano Nov 30, 2017

Contributor

lgtm

Contributor

ddelnano commented Nov 30, 2017

lgtm

@w-vi

w-vi approved these changes Nov 30, 2017

@honzajavorek honzajavorek merged commit ed234f5 into master Dec 1, 2017

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@honzajavorek

This comment has been minimized.

Show comment
Hide comment
@honzajavorek

honzajavorek Dec 1, 2017

Member

Thanks!

Member

honzajavorek commented Dec 1, 2017

Thanks!

@honzajavorek honzajavorek deleted the honzajavorek/gopath branch Dec 1, 2017

@pksunkara

This comment has been minimized.

Show comment
Hide comment
@pksunkara

pksunkara Dec 5, 2017

Member

Sorry about being late to review, but lgtm.

Member

pksunkara commented Dec 5, 2017

Sorry about being late to review, but lgtm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment