Adding fix for tomgco#14 to ensure req.url isn't getting passed to st…

…aticSend on error, only if directory Conflicts: lib/staticGzip.js
apiaryio · Feb 6, 2012 · 02db5ef · 02db5ef
1 parent 6f44430
commit 02db5ef
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/lib/staticGzip.js b/lib/staticGzip.js
@@ -156,8 +156,11 @@ exports = module.exports = function staticGzip(dirPath, options){
 		//Check file is not a directory
 
 		fs.stat(decodeURI(filename), function(err, stat) {
+			if (err) {
+				return pass(filename);
+			}
 
-			if (err || stat.isDirectory()) {
+			if (stat.isDirectory()) {
 				return pass(req.url);
 			}
 

diff --git a/test/staticGzipTest.js b/test/staticGzipTest.js
@@ -176,5 +176,15 @@ module.exports = {
 				res.statusCode.should.not.equal(404);
 			}
 		);
+	},
+	'Ensuring req.url isnt passed to staticSend on error': function() {
+		assert.response(getApp(),
+			{
+				url: '/etc/passwd'
+			},
+			function(res) {
+				res.statusCode.should.equal(404);
+			}
+		);
 	}
 };