New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cors headers support #6

Merged
merged 1 commit into from Apr 15, 2015

Conversation

Projects
None yet
3 participants
@XVincentX
Contributor

XVincentX commented Apr 14, 2015

I do not know if this is the best way to make it.
Anyway with this small change, CORS test passes.

Should close #5

@honzajavorek ?

image

@honzajavorek

This comment has been minimized.

Member

honzajavorek commented Apr 15, 2015

Looks good to me, but I'll leave the decision on @kylef. Also tests failed, but from superficial scanning of the results I do not understand why.

@XVincentX

This comment has been minimized.

Contributor

XVincentX commented Apr 15, 2015

@honzajavorek Not my fault.
#7

Vincenzo Chianese

@XVincentX XVincentX force-pushed the XVincentX/cors-enabled branch from 24fc0bc to 582001c Apr 15, 2015

kylef added a commit that referenced this pull request Apr 15, 2015

@kylef kylef merged commit 6125ae1 into master Apr 15, 2015

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@kylef kylef deleted the XVincentX/cors-enabled branch Apr 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment