From 85623a6ea55d0c21da322893ec10db5c9b676cbc Mon Sep 17 00:00:00 2001 From: jaipaljadeja Date: Tue, 22 Oct 2024 16:31:14 +0530 Subject: [PATCH] indexer: fix conditions in getDrizzleCursor --- ...ara-indexer-2ad98856-798e-4946-8109-02388d49f0e4.json | 7 +++++++ packages/indexer/src/sinks/drizzle/drizzle.test.ts | 9 +++------ packages/indexer/src/sinks/drizzle/utils.ts | 4 ++-- 3 files changed, 12 insertions(+), 8 deletions(-) create mode 100644 change/@apibara-indexer-2ad98856-798e-4946-8109-02388d49f0e4.json diff --git a/change/@apibara-indexer-2ad98856-798e-4946-8109-02388d49f0e4.json b/change/@apibara-indexer-2ad98856-798e-4946-8109-02388d49f0e4.json new file mode 100644 index 00000000..c8b617c1 --- /dev/null +++ b/change/@apibara-indexer-2ad98856-798e-4946-8109-02388d49f0e4.json @@ -0,0 +1,7 @@ +{ + "type": "prerelease", + "comment": "indexer: fix conditions in getDrizzleCursor", + "packageName": "@apibara/indexer", + "email": "jadejajaipal5@gmail.com", + "dependentChangeType": "patch" +} diff --git a/packages/indexer/src/sinks/drizzle/drizzle.test.ts b/packages/indexer/src/sinks/drizzle/drizzle.test.ts index fb982679..f799380e 100644 --- a/packages/indexer/src/sinks/drizzle/drizzle.test.ts +++ b/packages/indexer/src/sinks/drizzle/drizzle.test.ts @@ -9,16 +9,13 @@ import { drizzle } from "drizzle-orm/node-postgres"; import { serial, text } from "drizzle-orm/pg-core"; import { Client } from "pg"; import { beforeAll, beforeEach, describe, expect, it } from "vitest"; -import { - type Int8Range, - drizzle as drizzleSink, - getDrizzleCursor, - pgTable, -} from "."; import { useSink } from "../../hooks"; import { run } from "../../indexer"; import { generateMockMessages } from "../../testing"; import { getMockIndexer } from "../../testing/indexer"; +import type { Int8Range } from "./Int8Range"; +import { drizzle as drizzleSink } from "./drizzle"; +import { getDrizzleCursor, pgTable } from "./utils"; const testTable = pgTable("test_table", { id: serial("id").primaryKey(), diff --git a/packages/indexer/src/sinks/drizzle/utils.ts b/packages/indexer/src/sinks/drizzle/utils.ts index a049f003..71c3b876 100644 --- a/packages/indexer/src/sinks/drizzle/utils.ts +++ b/packages/indexer/src/sinks/drizzle/utils.ts @@ -83,10 +83,10 @@ export const getDrizzleCursor = ( const isArray = Array.isArray(cursor_range); const [lower, upper] = isArray ? cursor_range : [cursor_range, undefined]; let isNoUpperBound = false; - if (!lower) { + if (lower === undefined) { throw new Error("Lower bound cursor is required"); } - if (!upper) { + if (upper === undefined) { isNoUpperBound = true; } return new Int8Range(