Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

At init, selects the version shown as active (#868) #869

Merged
merged 2 commits into from Apr 27, 2020
Merged

At init, selects the version shown as active (#868) #869

merged 2 commits into from Apr 27, 2020

Conversation

Yopai
Copy link
Contributor

@Yopai Yopai commented Apr 26, 2020

This is a fix for a bug I encountered.

For readibility, I separated it in two commits :

  • a cleanup (just extract the code in a function)
  • an additional call to this function at init

Once you review this PR, I can squash the 2 in one single commit if you prefer.

@NicolasCARPi NicolasCARPi merged commit d29a622 into apidoc:dev Apr 27, 2020
@NicolasCARPi
Copy link
Collaborator

Thank you very much for your contribution. Indeed I was able to reproduce the issue you describe in #868 and your PR fixes this issue :)

@Yopai
Copy link
Contributor Author

Yopai commented Apr 27, 2020

Glad to have been helpful :)

@rafaelgomesxyz rafaelgomesxyz mentioned this pull request May 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Yopai @NicolasCARPi