From 752e68e960d28efec5f8ea70e3fd6308d957e13b Mon Sep 17 00:00:00 2001 From: Vlada Dusek Date: Thu, 3 Jul 2025 14:13:46 +0200 Subject: [PATCH 1/3] ci: Update Python versions for code checks --- .github/workflows/pre_release.yaml | 11 +++++++++++ .github/workflows/release.yaml | 11 +++++++++++ .github/workflows/run_code_checks.yaml | 11 +++++++---- 3 files changed, 29 insertions(+), 4 deletions(-) diff --git a/.github/workflows/pre_release.yaml b/.github/workflows/pre_release.yaml index adf7342d..1e07e2f5 100644 --- a/.github/workflows/pre_release.yaml +++ b/.github/workflows/pre_release.yaml @@ -11,6 +11,9 @@ on: # Or it can be triggered manually. workflow_dispatch: +env: + PYTHON_VERSIONS: '["3.10", "3.11", "3.12", "3.13"]' + jobs: release_metadata: if: "!startsWith(github.event.head_commit.message, 'docs') && !startsWith(github.event.head_commit.message, 'ci') && startsWith(github.repository, 'apify/')" @@ -31,14 +34,20 @@ jobs: lint_check: name: Lint check uses: apify/workflows/.github/workflows/python_lint_check.yaml@main + with: + python-version: ${{ env.PYTHON_VERSIONS }} type_check: name: Type check uses: apify/workflows/.github/workflows/python_type_check.yaml@main + with: + python-version: ${{ env.PYTHON_VERSIONS }} unit_tests: name: Unit tests uses: apify/workflows/.github/workflows/python_unit_tests.yaml@main + with: + python-version: ${{ env.PYTHON_VERSIONS }} async_docstrings: name: Async dostrings check @@ -48,6 +57,8 @@ jobs: name: Integration tests uses: apify/workflows/.github/workflows/python_integration_tests.yaml@main secrets: inherit + with: + python-version: ${{ env.PYTHON_VERSIONS }} update_changelog: name: Update changelog diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index 8316ab9b..22179901 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -21,6 +21,9 @@ on: type: string default: "" +env: + PYTHON_VERSIONS: '["3.10", "3.11", "3.12", "3.13"]' + jobs: release_metadata: name: Prepare release metadata @@ -42,14 +45,20 @@ jobs: lint_check: name: Lint check uses: apify/workflows/.github/workflows/python_lint_check.yaml@main + with: + python-version: ${{ env.PYTHON_VERSIONS }} type_check: name: Type check uses: apify/workflows/.github/workflows/python_type_check.yaml@main + with: + python-version: ${{ env.PYTHON_VERSIONS }} unit_tests: name: Unit tests uses: apify/workflows/.github/workflows/python_unit_tests.yaml@main + with: + python-version: ${{ env.PYTHON_VERSIONS }} async_docstrings: name: Async dostrings check @@ -59,6 +68,8 @@ jobs: name: Integration tests uses: apify/workflows/.github/workflows/python_integration_tests.yaml@main secrets: inherit + with: + python-version: ${{ env.PYTHON_VERSIONS }} update_changelog: name: Update changelog diff --git a/.github/workflows/run_code_checks.yaml b/.github/workflows/run_code_checks.yaml index 2d14eac7..95c7eb76 100644 --- a/.github/workflows/run_code_checks.yaml +++ b/.github/workflows/run_code_checks.yaml @@ -6,24 +6,27 @@ on: # step required for PRs from forks. This prevents their potential exposure. pull_request: +env: + PYTHON_VERSIONS: '["3.10", "3.11", "3.12", "3.13"]' + jobs: lint_check: name: Lint check uses: apify/workflows/.github/workflows/python_lint_check.yaml@main with: - python-version: '["3.10", "3.11", "3.12", "3.13"]' + python-version: ${{ env.PYTHON_VERSIONS }} type_check: name: Type check uses: apify/workflows/.github/workflows/python_type_check.yaml@main with: - python-version: '["3.10", "3.11", "3.12", "3.13"]' + python-version: ${{ env.PYTHON_VERSIONS }} unit_tests: name: Unit tests uses: apify/workflows/.github/workflows/python_unit_tests.yaml@main with: - python-version: '["3.10", "3.11", "3.12", "3.13"]' + python-version: ${{ env.PYTHON_VERSIONS }} async_docstrings: name: Async dostrings check @@ -38,5 +41,5 @@ jobs: needs: [lint_check, type_check, unit_tests] uses: apify/workflows/.github/workflows/python_integration_tests.yaml@main with: - python-version: '["3.10", "3.11", "3.12", "3.13"]' + python-version: ${{ env.PYTHON_VERSIONS }} secrets: inherit From 47dbe080d709c505a0092a07044e5c7744d423c6 Mon Sep 17 00:00:00 2001 From: Vlada Dusek Date: Thu, 3 Jul 2025 14:56:08 +0200 Subject: [PATCH 2/3] fix --- .github/workflows/pre_release.yaml | 11 ++++------- .github/workflows/release.yaml | 11 ++++------- .github/workflows/run_code_checks.yaml | 11 ++++------- 3 files changed, 12 insertions(+), 21 deletions(-) diff --git a/.github/workflows/pre_release.yaml b/.github/workflows/pre_release.yaml index 1e07e2f5..23ff049b 100644 --- a/.github/workflows/pre_release.yaml +++ b/.github/workflows/pre_release.yaml @@ -11,9 +11,6 @@ on: # Or it can be triggered manually. workflow_dispatch: -env: - PYTHON_VERSIONS: '["3.10", "3.11", "3.12", "3.13"]' - jobs: release_metadata: if: "!startsWith(github.event.head_commit.message, 'docs') && !startsWith(github.event.head_commit.message, 'ci') && startsWith(github.repository, 'apify/')" @@ -35,19 +32,19 @@ jobs: name: Lint check uses: apify/workflows/.github/workflows/python_lint_check.yaml@main with: - python-version: ${{ env.PYTHON_VERSIONS }} + python-version: '["3.10", "3.11", "3.12", "3.13"]' type_check: name: Type check uses: apify/workflows/.github/workflows/python_type_check.yaml@main with: - python-version: ${{ env.PYTHON_VERSIONS }} + python-version: '["3.10", "3.11", "3.12", "3.13"]' unit_tests: name: Unit tests uses: apify/workflows/.github/workflows/python_unit_tests.yaml@main with: - python-version: ${{ env.PYTHON_VERSIONS }} + python-version: '["3.10", "3.11", "3.12", "3.13"]' async_docstrings: name: Async dostrings check @@ -58,7 +55,7 @@ jobs: uses: apify/workflows/.github/workflows/python_integration_tests.yaml@main secrets: inherit with: - python-version: ${{ env.PYTHON_VERSIONS }} + python-version: '["3.10", "3.11", "3.12", "3.13"]' update_changelog: name: Update changelog diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index 22179901..533b000b 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -21,9 +21,6 @@ on: type: string default: "" -env: - PYTHON_VERSIONS: '["3.10", "3.11", "3.12", "3.13"]' - jobs: release_metadata: name: Prepare release metadata @@ -46,19 +43,19 @@ jobs: name: Lint check uses: apify/workflows/.github/workflows/python_lint_check.yaml@main with: - python-version: ${{ env.PYTHON_VERSIONS }} + python-version: '["3.10", "3.11", "3.12", "3.13"]' type_check: name: Type check uses: apify/workflows/.github/workflows/python_type_check.yaml@main with: - python-version: ${{ env.PYTHON_VERSIONS }} + python-version: '["3.10", "3.11", "3.12", "3.13"]' unit_tests: name: Unit tests uses: apify/workflows/.github/workflows/python_unit_tests.yaml@main with: - python-version: ${{ env.PYTHON_VERSIONS }} + python-version: '["3.10", "3.11", "3.12", "3.13"]' async_docstrings: name: Async dostrings check @@ -69,7 +66,7 @@ jobs: uses: apify/workflows/.github/workflows/python_integration_tests.yaml@main secrets: inherit with: - python-version: ${{ env.PYTHON_VERSIONS }} + python-version: '["3.10", "3.11", "3.12", "3.13"]' update_changelog: name: Update changelog diff --git a/.github/workflows/run_code_checks.yaml b/.github/workflows/run_code_checks.yaml index 95c7eb76..2d14eac7 100644 --- a/.github/workflows/run_code_checks.yaml +++ b/.github/workflows/run_code_checks.yaml @@ -6,27 +6,24 @@ on: # step required for PRs from forks. This prevents their potential exposure. pull_request: -env: - PYTHON_VERSIONS: '["3.10", "3.11", "3.12", "3.13"]' - jobs: lint_check: name: Lint check uses: apify/workflows/.github/workflows/python_lint_check.yaml@main with: - python-version: ${{ env.PYTHON_VERSIONS }} + python-version: '["3.10", "3.11", "3.12", "3.13"]' type_check: name: Type check uses: apify/workflows/.github/workflows/python_type_check.yaml@main with: - python-version: ${{ env.PYTHON_VERSIONS }} + python-version: '["3.10", "3.11", "3.12", "3.13"]' unit_tests: name: Unit tests uses: apify/workflows/.github/workflows/python_unit_tests.yaml@main with: - python-version: ${{ env.PYTHON_VERSIONS }} + python-version: '["3.10", "3.11", "3.12", "3.13"]' async_docstrings: name: Async dostrings check @@ -41,5 +38,5 @@ jobs: needs: [lint_check, type_check, unit_tests] uses: apify/workflows/.github/workflows/python_integration_tests.yaml@main with: - python-version: ${{ env.PYTHON_VERSIONS }} + python-version: '["3.10", "3.11", "3.12", "3.13"]' secrets: inherit From 8ed89239e2a8a9d587116fad06abcd10f6f5b624 Mon Sep 17 00:00:00 2001 From: Vlada Dusek Date: Thu, 3 Jul 2025 15:26:26 +0200 Subject: [PATCH 3/3] versions --- .github/workflows/pre_release.yaml | 8 ++++---- .github/workflows/release.yaml | 8 ++++---- .github/workflows/run_code_checks.yaml | 8 ++++---- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/.github/workflows/pre_release.yaml b/.github/workflows/pre_release.yaml index 23ff049b..fefe0509 100644 --- a/.github/workflows/pre_release.yaml +++ b/.github/workflows/pre_release.yaml @@ -32,19 +32,19 @@ jobs: name: Lint check uses: apify/workflows/.github/workflows/python_lint_check.yaml@main with: - python-version: '["3.10", "3.11", "3.12", "3.13"]' + python-versions: '["3.10", "3.11", "3.12", "3.13"]' type_check: name: Type check uses: apify/workflows/.github/workflows/python_type_check.yaml@main with: - python-version: '["3.10", "3.11", "3.12", "3.13"]' + python-versions: '["3.10", "3.11", "3.12", "3.13"]' unit_tests: name: Unit tests uses: apify/workflows/.github/workflows/python_unit_tests.yaml@main with: - python-version: '["3.10", "3.11", "3.12", "3.13"]' + python-versions: '["3.10", "3.11", "3.12", "3.13"]' async_docstrings: name: Async dostrings check @@ -55,7 +55,7 @@ jobs: uses: apify/workflows/.github/workflows/python_integration_tests.yaml@main secrets: inherit with: - python-version: '["3.10", "3.11", "3.12", "3.13"]' + python-versions: '["3.10", "3.11", "3.12", "3.13"]' update_changelog: name: Update changelog diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index 533b000b..641a7a8c 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -43,19 +43,19 @@ jobs: name: Lint check uses: apify/workflows/.github/workflows/python_lint_check.yaml@main with: - python-version: '["3.10", "3.11", "3.12", "3.13"]' + python-versions: '["3.10", "3.11", "3.12", "3.13"]' type_check: name: Type check uses: apify/workflows/.github/workflows/python_type_check.yaml@main with: - python-version: '["3.10", "3.11", "3.12", "3.13"]' + python-versions: '["3.10", "3.11", "3.12", "3.13"]' unit_tests: name: Unit tests uses: apify/workflows/.github/workflows/python_unit_tests.yaml@main with: - python-version: '["3.10", "3.11", "3.12", "3.13"]' + python-versions: '["3.10", "3.11", "3.12", "3.13"]' async_docstrings: name: Async dostrings check @@ -66,7 +66,7 @@ jobs: uses: apify/workflows/.github/workflows/python_integration_tests.yaml@main secrets: inherit with: - python-version: '["3.10", "3.11", "3.12", "3.13"]' + python-versions: '["3.10", "3.11", "3.12", "3.13"]' update_changelog: name: Update changelog diff --git a/.github/workflows/run_code_checks.yaml b/.github/workflows/run_code_checks.yaml index 2d14eac7..afdb0cee 100644 --- a/.github/workflows/run_code_checks.yaml +++ b/.github/workflows/run_code_checks.yaml @@ -11,19 +11,19 @@ jobs: name: Lint check uses: apify/workflows/.github/workflows/python_lint_check.yaml@main with: - python-version: '["3.10", "3.11", "3.12", "3.13"]' + python-versions: '["3.10", "3.11", "3.12", "3.13"]' type_check: name: Type check uses: apify/workflows/.github/workflows/python_type_check.yaml@main with: - python-version: '["3.10", "3.11", "3.12", "3.13"]' + python-versions: '["3.10", "3.11", "3.12", "3.13"]' unit_tests: name: Unit tests uses: apify/workflows/.github/workflows/python_unit_tests.yaml@main with: - python-version: '["3.10", "3.11", "3.12", "3.13"]' + python-versions: '["3.10", "3.11", "3.12", "3.13"]' async_docstrings: name: Async dostrings check @@ -38,5 +38,5 @@ jobs: needs: [lint_check, type_check, unit_tests] uses: apify/workflows/.github/workflows/python_integration_tests.yaml@main with: - python-version: '["3.10", "3.11", "3.12", "3.13"]' + python-versions: '["3.10", "3.11", "3.12", "3.13"]' secrets: inherit