Skip to content

Conversation

@jirispilka
Copy link
Collaborator

@jirispilka jirispilka commented May 16, 2025

  • fix: Use a new API to get Actor default build`
  • feat: add get-actor and get-user-runs-list
  • feat: add dataset, Actor runs, fix tests

Closes: #79

Ideally, when using Actorized MCP servers we should add information about dataset and Actor run into context but for that we need to fix this issue first: apify/tester-mcp-client#67

@github-actions github-actions bot added the t-ai Issues owned by the AI team. label May 16, 2025
@jirispilka jirispilka changed the title feat: Add Actor runs API, dataset API feat: Add Actor runs API, dataset API, KV-store May 19, 2025
@jirispilka jirispilka requested a review from MQ37 May 19, 2025 12:58
Copy link
Contributor

@MQ37 MQ37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment otherwise LGTM 👍

@github-actions github-actions bot added the tested Temporary label used only programatically for some analytics. label May 21, 2025
@jirispilka
Copy link
Collaborator Author

@MQ37 This PR has grown quite a bit — sorry about that! Once again, we ended up working on the same part of the code, and when I started fixing the unit tests, I went down a rabbit hole and couldn’t stop myself. 😅

I really like the tests you added — they’re super helpful, thanks!

That said, there’s one test I believe is tied to the reset function, which always loads the default Actor. So even when the server is called with a specific Actor selected, the default one still gets loaded — which shouldn’t happen.

We’ll need to fix that.

Also, I ran into an issue where, after the test completed, the process was still hanging around and consuming 100% CPU.

If you could please review again. Mainly the test suite and mcp/server.ts 🙏🏻

@jirispilka jirispilka requested a review from MQ37 May 21, 2025 21:36
Copy link
Contributor

@MQ37 MQ37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor, thank you 👍 Just one issue with the Actorized MCP server tools listing otherwise LGTM

@jirispilka jirispilka requested a review from MQ37 May 26, 2025 08:51
Copy link
Contributor

@MQ37 MQ37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 We will fix the test reset func later

@jirispilka jirispilka merged commit 7b99e85 into master May 26, 2025
2 checks passed
@jirispilka jirispilka deleted the feat/add-actor-tools branch May 26, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-ai Issues owned by the AI team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add more tools: dataset access, Actor logs

2 participants