Skip to content

ci: auto set dxt version on release #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 27, 2025
Merged

ci: auto set dxt version on release #244

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
527d0d7
ci: auto set dxt version on release
MQ37 Aug 27, 2025
6040d12
temp: do not push to npm for testing
MQ37 Aug 27, 2025
5e5c477
fix: use latest git ref with the updated versions
MQ37 Aug 27, 2025
d9bda2c
add cheks and debug logs
MQ37 Aug 27, 2025
9478ff5
more logging and cheks
MQ37 Aug 27, 2025
073cbaf
try to fix the ref handling
MQ37 Aug 27, 2025
3bff84d
fix output of commit step
MQ37 Aug 27, 2025
ce00993
fix outputs facepam
MQ37 Aug 27, 2025
160a231
remove debug steps, keep the checks that fail the job on version mis…
MQ37 Aug 27, 2025
98a193d
try with original output
MQ37 Aug 27, 2025
89d198e
add version checks also to the npm publish job
MQ37 Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 61 additions & 4 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,9 @@ jobs:
- name: Update package version in package.json
run: npm version --no-git-tag-version --allow-same-version ${{ needs.release_metadata.outputs.version_number }}

- name: Update manifest.json version
run: jq '.version = "${{ needs.release_metadata.outputs.version_number }}"' manifest.json > manifest.json.tmp && mv manifest.json.tmp manifest.json

- name: Update CHANGELOG.md
uses: DamianReeves/write-file-action@master
with:
Expand All @@ -77,7 +80,7 @@ jobs:
with:
author_name: Apify Release Bot
author_email: noreply@apify.com
message: "chore(release): Update changelog and package version [skip ci]"
message: "chore(release): Update changelog, package.json and manifest.json versions [skip ci]"

create_github_release:
name: Create github release
Expand All @@ -88,7 +91,34 @@ jobs:
steps:
- uses: actions/checkout@v4
with:
ref: ${{ needs.update_changelog.changelog_commitish }}
ref: ${{ needs.update_changelog.outputs.changelog_commitish }}
- name: Verify commit SHA
run: |
CURRENT_SHA=$(git rev-parse HEAD)
EXPECTED_SHA="${{ needs.update_changelog.outputs.changelog_commitish }}"
echo "Expected commit SHA: $EXPECTED_SHA"
echo "Actual checked out SHA: $CURRENT_SHA"
if [ "$EXPECTED_SHA" != "$CURRENT_SHA" ]; then
echo "ERROR: Checked out SHA differs from expected!"
exit 1
else
echo "✓ Commit SHA matches expected"
fi
- name: Verify manifest.json version
run: |
EXPECTED_VERSION="${{ needs.release_metadata.outputs.version_number }}"
ACTUAL_VERSION=$(jq -r '.version' manifest.json)

echo "Expected version: $EXPECTED_VERSION"
echo "Actual version in manifest.json: $ACTUAL_VERSION"
echo "Current commit SHA: ${{ needs.update_changelog.outputs.changelog_commitish }}"

if [ "$EXPECTED_VERSION" != "$ACTUAL_VERSION" ]; then
echo "ERROR: Version mismatch! Expected $EXPECTED_VERSION but found $ACTUAL_VERSION in manifest.json"
exit 1
fi

echo "✓ Version check passed: manifest.json has correct version $ACTUAL_VERSION"
- name: Use Node.js 22
uses: actions/setup-node@v4
with:
Expand Down Expand Up @@ -124,12 +154,39 @@ jobs:

publish_to_npm:
name: Publish to NPM
needs: [ update_changelog ]
needs: [ release_metadata, update_changelog ]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
ref: ${{ needs.update_changelog.changelog_commitish }}
ref: ${{ needs.update_changelog.outputs.changelog_commitish }}
- name: Verify commit SHA
run: |
CURRENT_SHA=$(git rev-parse HEAD)
EXPECTED_SHA="${{ needs.update_changelog.outputs.changelog_commitish }}"
echo "Expected commit SHA: $EXPECTED_SHA"
echo "Actual checked out SHA: $CURRENT_SHA"
if [ "$EXPECTED_SHA" != "$CURRENT_SHA" ]; then
echo "ERROR: Checked out SHA differs from expected!"
exit 1
else
echo "✓ Commit SHA matches expected"
fi
- name: Verify manifest.json version
run: |
EXPECTED_VERSION="${{ needs.release_metadata.outputs.version_number }}"
ACTUAL_VERSION=$(jq -r '.version' manifest.json)

echo "Expected version: $EXPECTED_VERSION"
echo "Actual version in manifest.json: $ACTUAL_VERSION"
echo "Current commit SHA: ${{ needs.update_changelog.outputs.changelog_commitish }}"

if [ "$EXPECTED_VERSION" != "$ACTUAL_VERSION" ]; then
echo "ERROR: Version mismatch! Expected $EXPECTED_VERSION but found $ACTUAL_VERSION in manifest.json"
exit 1
fi

echo "✓ Version check passed: manifest.json has correct version $ACTUAL_VERSION"
- name: Use Node.js 22
uses: actions/setup-node@v4
with:
Expand Down