Skip to content

Commit

Permalink
fix: log status message only once and without prefix (#179)
Browse files Browse the repository at this point in the history
  • Loading branch information
barjin authored Mar 23, 2023
1 parent 27edd99 commit 1f11a6a
Showing 1 changed file with 6 additions and 8 deletions.
14 changes: 6 additions & 8 deletions packages/apify/src/actor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -250,13 +250,11 @@ export class Actor<Data extends Dictionary = Dictionary> {

if (options.exitCode > 0) {
options.statusMessage ??= `Actor finished with an error (exit code ${options.exitCode})`;
log.error(options.statusMessage);
} else {
options.statusMessage ??= `Actor finished successfully (exit code ${options.exitCode})`;
log.info(options.statusMessage);
}

await this.setStatusMessage(options.statusMessage, { isStatusMessageTerminal: true });
await this.setStatusMessage(options.statusMessage, { isStatusMessageTerminal: true, level: options.exitCode > 0 ? LogLevel.ERROR : LogLevel.INFO });

if (!options.exit) {
return;
Expand Down Expand Up @@ -519,20 +517,20 @@ export class Actor<Data extends Dictionary = Dictionary> {
ow(statusMessage, ow.string);
ow(isStatusMessageTerminal, ow.optional.boolean);

statusMessage = `[Status message]: ${statusMessage}`;
const loggedStatusMessage = `[Status message]: ${statusMessage}`;

switch (level) {
case LogLevel.DEBUG:
log.debug(statusMessage);
log.debug(loggedStatusMessage);
break;
case LogLevel.WARNING:
log.warning(statusMessage);
log.warning(loggedStatusMessage);
break;
case LogLevel.ERROR:
log.error(statusMessage);
log.error(loggedStatusMessage);
break;
default:
log.info(statusMessage);
log.info(loggedStatusMessage);
break;
}

Expand Down

0 comments on commit 1f11a6a

Please sign in to comment.